Closed
Bug 1082530
Opened 10 years ago
Closed 10 years ago
Make Moz2D's UserToDevicePixelSnapped honor disabling of pixel snapping and scale ignoring as gfxContext::UserToDevicePixelSnapped does
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(5 files)
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
See bug 989858 comment 25 - comment 27.
Bug 989858 part 6 replaced a call to gfxContext::UserToDevicePixelSnapped() with a call to the new Moz2D helper of the same name. These functions aren't equivalent though since the Moz2D version doesn't (isn't able to) check for the presence of the FLAG_DISABLE_SNAPPING flag. The Moz2D variant also doesn't have an ignoreScale argument, so the converted caller has changed in that regard too.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8504678 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8504679 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8504681 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8504683 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8504684 -
Flags: review?(matt.woodrow)
Updated•10 years ago
|
Attachment #8504678 -
Flags: review?(matt.woodrow) → review+
Updated•10 years ago
|
Attachment #8504679 -
Flags: review?(matt.woodrow) → review+
Updated•10 years ago
|
Attachment #8504681 -
Flags: review?(matt.woodrow) → review+
Updated•10 years ago
|
Attachment #8504683 -
Flags: review?(matt.woodrow) → review+
Updated•10 years ago
|
Attachment #8504684 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a45f83eeda1
https://hg.mozilla.org/integration/mozilla-inbound/rev/61c3d66c10a1
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce005765cf43
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f6dc495c8b6
https://hg.mozilla.org/integration/mozilla-inbound/rev/1abfecf86c50
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9a45f83eeda1
https://hg.mozilla.org/mozilla-central/rev/61c3d66c10a1
https://hg.mozilla.org/mozilla-central/rev/ce005765cf43
https://hg.mozilla.org/mozilla-central/rev/5f6dc495c8b6
https://hg.mozilla.org/mozilla-central/rev/1abfecf86c50
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•