Closed
Bug 1082627
Opened 10 years ago
Closed 10 years ago
(App-grouping) Collapsed groups should align to the left
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: cwiiis, Assigned: cwiiis)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
kgrandon
:
review+
hnguyen
:
ui-review+
|
Details |
Currently collapsed groups align center - they should align to the left.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8504780 -
Flags: review?(kgrandon)
Assignee | ||
Updated•10 years ago
|
Summary: Collapsed groups should align to the left → (App-grouping) Collapsed groups should align to the left
Comment 2•10 years ago
|
||
Hey Chris - I hate to be a pain, but I think we're getting to the point where we should start landing these fixes with marionette tests where possible. Perhaps the test should do something like assert on the position of the first icon in a collapsed small group, vs a collapsed large group. Icon.getBoundingClientRect().left should take the transform effect into account.
Would you mind giving an integration test a spin before landing?
Flags: needinfo?(chrislord.net)
Updated•10 years ago
|
Attachment #8504780 -
Flags: ui-review?(hnguyen)
Comment 3•10 years ago
|
||
Comment on attachment 8504780 [details]
Align collapsed groups to the left
Clearing code review for now, until the question about the test is addressed.
Attachment #8504780 -
Flags: review?(kgrandon)
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Kevin Grandon :kgrandon from comment #2)
> Hey Chris - I hate to be a pain, but I think we're getting to the point
> where we should start landing these fixes with marionette tests where
> possible. Perhaps the test should do something like assert on the position
> of the first icon in a collapsed small group, vs a collapsed large group.
> Icon.getBoundingClientRect().left should take the transform effect into
> account.
>
> Would you mind giving an integration test a spin before landing?
Sure, I'll give it a go.
Flags: needinfo?(chrislord.net)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8504780 [details]
Align collapsed groups to the left
Added marionette test.
Attachment #8504780 -
Flags: review?(kgrandon)
Updated•10 years ago
|
Attachment #8504780 -
Flags: ui-review?(hnguyen) → ui-review+
Updated•10 years ago
|
Attachment #8504780 -
Flags: review?(kgrandon) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•