J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Description • 10 years ago

Bug 1081093 adds auto-install support for the tools adapter add-on, but leaves it disabled for now.

Once the add-on is ready for wider distribution, we should flip it on.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 1 • 10 years ago

Ready for review, but don't land yet, as there still changes to make to the add-on first.

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a84debbe2576

	Paul Rouget [:paul]
	Comment 2 • 10 years ago

Comment on attachment 8509514 [details] [diff] [review]
Enable auto-install tools adapter add-on

Let me take that back.

If we land that in Aurora, it will go to beta and release without going through nightly. I'm not even sure we want this to be enabled in vanilla firefox.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 3 • 10 years ago

Well, we could put it in the Aurora-only prefs, so it's fixed for Dev Edition only.

Or, the current patch could land in Nightly (and be uplifted to Aurora), and keep riding the trains up to Release.

Dave, what's your opinion?  Should Valence / Fever Dream auto-install be Dev Edition only, or ride the trains and install on WebIDE open for any channel eventually?

	Paul Rouget [:paul]
	Comment 4 • 10 years ago

(In reply to J. Ryan Stinnett [:jryans] from comment #3)
> Well, we could put it in the Aurora-only prefs, so it's fixed for Dev
> Edition only.

Let's do that for now.

	Paul Rouget [:paul]
	Comment 5 • 10 years ago

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #4)
> (In reply to J. Ryan Stinnett [:jryans] from comment #3)
> > Well, we could put it in the Aurora-only prefs, so it's fixed for Dev
> > Edition only.
> 
> Let's do that for now.

This will happen in bug 1082584.

	Paul Rouget [:paul]
	Comment 6 • 10 years ago

Comment on attachment 8509514 [details] [diff] [review]
Enable auto-install tools adapter add-on

Let's land in Firefox Nightly after we got some feedback from devedition ... ironic :)

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 7 • 10 years ago

Okay, sounds fine.  This bug no longer blocks Dev Edition then.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 9 • 10 years ago

Dave / Axel / Jeff, should we proceed with Valence auto-install on WebIDE open in all channels, or leave it restricted to Dev Edition?

	Jeff Griffiths (:canuckistani) (:⚡︎)
	Comment 10 • 10 years ago

I think if they've opened WebIDE, then sure.

	Axel Kratel
	Comment 11 • 10 years ago

I concurr, if they've opened WebIDE, then go ahead and auto install.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 12 • 10 years ago

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d57e1a225198

	Carsten Book [:Tomcat]
	Comment 13 • 10 years ago

Hi, this patch failed to apply:

adding 1082632 to series file
renamed 1082632 -> 0001-Bug-1082632-Enable-Valence-auto-install-for-all-chan.patch
applying 0001-Bug-1082632-Enable-Valence-auto-install-for-all-chan.patch
patching file browser/devtools/webide/webide-prefs.js
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file browser/devtools/webide/webide-prefs.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 0001-Bug-1082632-Enable-Valence-auto-install-for-all-chan.patch

could you take a look, thanks!

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 14 • 10 years ago

Rebase, pushed to fx-team:

https://hg.mozilla.org/integration/fx-team/rev/43596e7e4086

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/43596e7e4086

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 16 • 10 years ago

relnoted as "Debug tabs in Chrome Desktop, Chrome for Android, and Safari for iOS".

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow) Assignee
	Comment 17 • 10 years ago

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #16)
> relnoted as "Debug tabs in Chrome Desktop, Chrome for Android, and Safari
> for iOS".

I realize I wrote this wording...  

But I think adding "opened" as in "Debug tabs opened in Chrome Desktop, Chrome for Android, and Safari for iOS" is better, to make it clearer that the *debugging* takes place in Firefox, not in the other browsers somehow.

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 18 • 10 years ago

OK. Makes sense to me. I have updated the note. Thanks for the improvement.