Closed
Bug 1082957
Opened 10 years ago
Closed 10 years ago
Make it possible to build the JS engine in debug mode without JS_CRASH_DIAGNOSTICS
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8505146 -
Flags: review?(wmccloskey)
Comment on attachment 8505146 [details] [diff] [review]
Make it possible to build the JS engine in debug mode without JS_CRASH_DIAGNOSTICS
Review of attachment 8505146 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jscntxtinlines.h
@@ +161,5 @@
>
> template <class T1> inline void
> assertSameCompartmentDebugOnly(ThreadSafeContext *cx, const T1 &t1)
> {
> +#ifdef JS_CRASH_DIAGNOSTICS
This needs to be #if defined(DEBUG) && defined(JS_CRASH_DIAGNOSTICS).
Attachment #8505146 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Ah, right!
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•