Open Bug 108296 Opened 23 years ago Updated 16 years ago

Front-end for link checker

Categories

(SeaMonkey :: Composer, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: akkzilla, Unassigned)

References

Details

(Keywords: polish, Whiteboard: [adt3])

Attachments

(1 file, 2 obsolete files)

The link checker backend works, but we need a way to display it that's better than printing to stdout. Even a simple UI would be enough to allow us to turn it on in the UI.
The backend broke temporarily; there's a patch in bug 91388 for that.
Depends on: 91388
Will do this soon!
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.7
Darn, didn't finish in time for 0.9.7
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Depends on: 112985
Depends on: 115140
Depends on: 115318
Attached patch First draft to use for testing (obsolete) (deleted) — Splinter Review
Whiteboard: FIX IN HAND, need r=,sr= (for first draft)
Comment on attachment 63903 [details] [diff] [review] First draft to use for testing r=akkana
Attachment #63903 - Flags: review+
Whiteboard: FIX IN HAND, need r=,sr= (for first draft) → FIX IN HAND, need sr= (for first draft)
Charley's patch is messed up, line numbers that don't correspond to the actual number of lines in the patch, etc. I'm about to attach a patch that should (I hope) work better. But it doesn't work for me -- the dialog is blank, and stays blank even after stdout messages say that the callback has fired. I don't think the checker code is quite working, either; I'm getting a dump of Exception ERROR in Link checker. e.result=2147746065, gNumLinksToCheck=4 for every link, even links that do exist. So something is wrong (perhaps in the way I hand-applied the patch?)
Attachment #63903 - Attachment is obsolete: true
It was difficult to produce a clean patch because of conflicts with other fixes in my tree. I checked my files based on the "first draft" patch, which did work (i.e., did display dialog without the exception error.) I'll reconcile with Akkana's patch next.
moving milestone
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Whiteboard: FIX IN HAND, need sr= (for first draft)
Depends on: 118719
The addref problem causing the crash described above is fixed. We can proceed with this, which is closely related to the publishing feature.
Keywords: nsbeta1+
changing milestone
Target Milestone: mozilla0.9.9 → mozilla1.0
Attached patch patch v3 (deleted) — Splinter Review
This leverages new Publish Progress patterns to show a simple listbox of links to be checked. In this version, I get an exception error after finding the first link to check.
Attachment #64434 - Attachment is obsolete: true
Please update this bug with an [adt1] - [adt3] impact rating (or take it off the list if it doesn't even rate adt3.) Thanks!
not going to make it for 1.0
Target Milestone: mozilla1.0 → mozilla1.2alpha
Keywords: nsbeta1+nsbeta1-
Target Milestone: mozilla1.2alpha → mozilla1.2beta
Keywords: nsbeta1-nsbeta1
nsbeta1+ per buffy triage
Keywords: nsbeta1nsbeta1+
Keywords: polish
Composer triage team: nsbeta1+/adt2 It appears we need to move the ``Check Links'' menuitem from the ``Debug'' menu to the ``Tools'' menu.
Assignee: cmanske → jaggernaut
Status: ASSIGNED → NEW
Whiteboard: [adt2]
Target Milestone: mozilla1.2beta → mozilla1.4alpha
Composer triage team: nsbeta1+/adt3
Whiteboard: [adt2] → [adt3]
Target Milestone: mozilla1.4alpha → mozilla1.4beta
Nav triage team: nsbeta1-
Keywords: nsbeta1+nsbeta1-
Product: Browser → Seamonkey
(In reply to comment #17) > It appears we need to move the ``Check Links'' menuitem from the ``Debug'' menu > to the ``Tools'' menu. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1pre) Gecko/2008062601 SeaMonkey/2.0a1pre "Check Links" is still under "Debug" (in the Composer window). So: Jag, are you still working on this, should it be reassigned to nobody@ -- or else resolved WONTFIX? (BTW, I'm removing "Mozilla 1.4 beta" as the target milestone. Feel free to set something more realistic.)
QA Contact: sujay → composer
Target Milestone: mozilla1.4beta → ---
Assignee: jag → nobody
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: