Open
Bug 108296
Opened 23 years ago
Updated 16 years ago
Front-end for link checker
Categories
(SeaMonkey :: Composer, defect)
Tracking
(Not tracked)
NEW
People
(Reporter: akkzilla, Unassigned)
References
Details
(Keywords: polish, Whiteboard: [adt3])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
The link checker backend works, but we need a way to display it that's better
than printing to stdout. Even a simple UI would be enough to allow us to turn
it on in the UI.
Reporter | ||
Comment 1•23 years ago
|
||
The backend broke temporarily; there's a patch in bug 91388 for that.
Depends on: 91388
Comment 2•23 years ago
|
||
Will do this soon!
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.7
Comment 3•23 years ago
|
||
Darn, didn't finish in time for 0.9.7
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Comment 4•23 years ago
|
||
Updated•23 years ago
|
Whiteboard: FIX IN HAND, need r=,sr= (for first draft)
Comment 5•23 years ago
|
||
Comment on attachment 63903 [details] [diff] [review]
First draft to use for testing
r=akkana
Attachment #63903 -
Flags: review+
Updated•23 years ago
|
Whiteboard: FIX IN HAND, need r=,sr= (for first draft) → FIX IN HAND, need sr= (for first draft)
Comment 6•23 years ago
|
||
Comment on attachment 63903 [details] [diff] [review]
First draft to use for testing
sr=ben@netscape.com
Attachment #63903 -
Flags: superreview+
Reporter | ||
Comment 7•23 years ago
|
||
Charley's patch is messed up, line numbers that don't correspond to the actual
number of lines in the patch, etc. I'm about to attach a patch that should (I
hope) work better. But it doesn't work for me -- the dialog is blank, and stays
blank even after stdout messages say that the callback has fired.
I don't think the checker code is quite working, either; I'm getting a dump of
Exception ERROR in Link checker. e.result=2147746065, gNumLinksToCheck=4
for every link, even links that do exist. So something is wrong (perhaps in the
way I hand-applied the patch?)
Reporter | ||
Comment 8•23 years ago
|
||
Attachment #63903 -
Attachment is obsolete: true
Comment 9•23 years ago
|
||
It was difficult to produce a clean patch because of conflicts with other
fixes in my tree. I checked my files based on the "first draft" patch, which did
work (i.e., did display dialog without the exception error.) I'll reconcile with
Akkana's patch next.
Updated•23 years ago
|
Whiteboard: FIX IN HAND, need sr= (for first draft)
Comment 11•23 years ago
|
||
The addref problem causing the crash described above is fixed. We can proceed with
this, which is closely related to the publishing feature.
Keywords: nsbeta1+
Comment 13•23 years ago
|
||
This leverages new Publish Progress patterns to show a simple
listbox of links to be checked.
In this version, I get an exception error after finding the first link to
check.
Attachment #64434 -
Attachment is obsolete: true
Comment 14•23 years ago
|
||
Please update this bug with an [adt1] - [adt3] impact rating (or take it off the
list if it doesn't even rate adt3.) Thanks!
Comment 15•23 years ago
|
||
not going to make it for 1.0
Target Milestone: mozilla1.0 → mozilla1.2alpha
Updated•22 years ago
|
Target Milestone: mozilla1.2alpha → mozilla1.2beta
Updated•22 years ago
|
Comment 17•22 years ago
|
||
Composer triage team: nsbeta1+/adt2
It appears we need to move the ``Check Links'' menuitem from the ``Debug'' menu
to the ``Tools'' menu.
Assignee: cmanske → jaggernaut
Status: ASSIGNED → NEW
Whiteboard: [adt2]
Updated•22 years ago
|
Target Milestone: mozilla1.2beta → mozilla1.4alpha
Updated•22 years ago
|
Target Milestone: mozilla1.4alpha → mozilla1.4beta
Updated•20 years ago
|
Product: Browser → Seamonkey
Comment 20•16 years ago
|
||
(In reply to comment #17)
> It appears we need to move the ``Check Links'' menuitem from the ``Debug'' menu
> to the ``Tools'' menu.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1pre) Gecko/2008062601 SeaMonkey/2.0a1pre
"Check Links" is still under "Debug" (in the Composer window).
So: Jag, are you still working on this, should it be reassigned to nobody@ -- or else resolved WONTFIX? (BTW, I'm removing "Mozilla 1.4 beta" as the target milestone. Feel free to set something more realistic.)
QA Contact: sujay → composer
Target Milestone: mozilla1.4beta → ---
Updated•16 years ago
|
Assignee: jag → nobody
You need to log in
before you can comment on or make changes to this bug.
Description
•