Closed
Bug 1082983
Opened 10 years ago
Closed 10 years ago
Enable the Windows console in ASAN builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
These builds are not very useful without a console, which is
where the ASAN reports go to.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8505201 -
Flags: review?(mh+mozilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8505201 [details] [diff] [review]
Enable the Windows console in ASAN builds
Review of attachment 8505201 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/app/Makefile.in
@@ +24,5 @@
>
> # Build a binary bootstrapping with XRE_main
>
> ifndef MOZ_WINCONSOLE
> ifdef MOZ_DEBUG
ifneq (,$(MOZ_DEBUG)$(MOZ_ASAN))
That's how you write if defined(MOZ_DEBUG) || defined(MOZ_ASAN) in make terms.
Attachment #8505201 -
Flags: review?(mh+mozilla) → review+
|
||
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•