Closed
Bug 1083068
Opened 10 years ago
Closed 10 years ago
Improve uncaught promise rejection helper in tests
Categories
(Mozilla Labs :: Jetpack SDK, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
irakli
:
review+
|
Details | Diff | Splinter Review |
The helper to notify in unit test about uncaught promise rejection displays a useless stack and doesn't expose the rejection message.
It ends up being really difficult to know which promise is failing, you basically just know one has been rejected... somewhere :s
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8505335 -
Flags: review?(rFobic)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8505335 [details] [diff] [review]
patch
Review of attachment 8505335 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me
Attachment #8505335 -
Flags: review?(rFobic) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
There is some failure in the try run, but it looks like the same failure that already happen on m-c?
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 7•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/1aee56d5ef161f47beb5ee6197cc4598956e6010
Bug 1083068 - Improve SDK logging when a promise is rejected during tests. r=gozala
You need to log in
before you can comment on or make changes to this bug.
Description
•