Closed
Bug 1083104
Opened 10 years ago
Closed 10 years ago
incorrect line-breaking within embedded spans in vertical writing mode
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
In vertical writing mode, we appear to do line-breaking OK within a simple block, but if there are embedded spans (<b> or <i> elements, etc) within the line, we get totally inappropriate breaks; it looks like the wrong available width must be getting passed to the child elements for line-breaking purposes.
Testcase attached; set the writing mode to vertical-lr and use the slider to vary the size of the <div> within which the text is being displayed.
(In vertical-rl mode, the same line-breaking issues occur, but the display is further confused due to bug 1082844 displaying fragments in the wrong places.)
Assignee | ||
Comment 1•10 years ago
|
||
This one turned out to be a trivial oversight from bug 789096. :)
Attachment #8505410 -
Flags: review?(smontagu)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8505410 [details] [diff] [review]
Fix misuse of physical instead of logical dimension for line breaking.
Review of attachment 8505410 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, thank you for catching that.
Attachment #8505410 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Target Milestone: --- → mozilla36
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•