Closed
Bug 108321
Opened 23 years ago
Closed 23 years ago
~30% of HTMLContentSink::AddAttributes() spent in the component manager.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file)
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
For every HTML element that has attributes we use the component manager to
create the nsHTMLAttributes object that holds the attributes in stead of just
simply calling NS_NewHTMLAttributes(), duh!
Patch coming up that fixes the performance problems and cleans up
nsHTMLStyleSheet.cpp quite a bit.
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
Waterson, dp, reviews?
Comment 3•23 years ago
|
||
PRInt32 nameSpace;
styledContent->GetNameSpaceID(nameSpace);
if (kNameSpaceID_HTML == nameSpace) {
Change the above to IsContentOfType.
sr=hyatt
Comment 4•23 years ago
|
||
Comment on attachment 56378 [details] [diff] [review]
Don't use the component manager to create the attributes holder, and clean things up a bit...
r=dbaron
Attachment #56378 -
Flags: review+
Assignee | ||
Comment 5•23 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Component: DOM: HTML → DOM: Core & HTML
QA Contact: stummala → general
You need to log in
before you can comment on or make changes to this bug.
Description
•