Boris Zbarsky [:bzbarsky] Assignee
	Description • 10 years ago

That way we avoid reallocating and running FrameState ctors/dtors as we capture a stack.

What's a good minimum size here?

If we can get away with 100, that would be nice, since that's the default stack depth console captures....  The MaxReportedStackDepth that Error uses is clearly too much.  ;)

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 1 • 10 years ago

So at first glance, FrameState is 5 words: principals, name, and 3 words for LocationValue (source, line, column).

So allocating an array of length N will use 20N bytes on 32-bit, and 40N bytes on 64-bit.

We probably shouldn't go higher than 20 or so for the auto length...

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]
	Comment 3 • 10 years ago

Comment on attachment 8505958 [details] [diff] [review]
Give FrameStateVector a nonzero minimal length, so we don't end up doing a bunch of realloc/copy as we walk our stack

Review of attachment 8505958 [details] [diff] [review]:
-----------------------------------------------------------------

(Note that I'm not technically a SpiderMonkey peer, not sure that's a big deal in this specific case, though...)

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 4 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/b83e5b5a80da

	Carsten Book [:Tomcat]
	Comment 5 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/b83e5b5a80da