Boris Zbarsky [:bzbarsky] Assignee
	Description • 10 years ago

Seems to me like the FrameState has C-stack-lifetime and during its lifetime the principals are kept alive by the JS callstack that we're walking....  So we shouldn't need to hold/drop them in FrameState() and ~FrameState().

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]
	Comment 1 • 10 years ago

+1 let's drop the drops.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]
	Comment 3 • 10 years ago

Comment on attachment 8505957 [details] [diff] [review]
Don't refcount the principals in FrameState, since it has stack lifetime and the principals will be kept alive by the JS stack while he FrameState is alive

Review of attachment 8505957 [details] [diff] [review]:
-----------------------------------------------------------------

Might be worth a short comment blurb explaining why we don't need to hold principals, for the inquisitive reader of the future.

Again, note that I'm not a SpiderMonkey peer.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 4 • 10 years ago

Added a note in the header:

        // Note: we don't have to hold/drop principals, because we're
        // only alive while the stack is being walked and during this
        // time the principals are kept alive by the stack itself.

As far as peerness, I think we're OK; jimb was ok with this as well, for example.  And you're the domain expert on this code anyway.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 5 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/01d25edea2bc

	Carsten Book [:Tomcat]
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/01d25edea2bc