Closed Bug 1083540 Opened 10 years ago Closed 10 years ago

Dialer - Hang Up Icon could be more clear

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: padamczyk, Assigned: pivanov)

References

Details

Attachments

(6 files)

Can we change the hang up iconography to be more clear, what about a handset with a slash through it?
Assignee: chuang → pla
I can take it, please assign me when the icon is ready :)
Attached file New Hang Up Icon Exported @ 5 Sizes (deleted) —
Pavel, here is the set of icons. :)

Thanks!
Assignee: pla → pivanov
Attached file patch for Gaia/master (deleted) —
Attachment #8525527 - Flags: ui-review?(pla)
Comment on attachment 8525527 [details]
patch for Gaia/master

Hey Pavel,

I tested it on my Flame and for some reason it's using a lower-res image and scaling it up.  I also noticed the icon seems a little low but this is a bitmap issue on my end.  I'll revise the icons and upload a new set.

Thanks!
Attachment #8525527 - Flags: ui-review?(pla) → ui-review-
Pavel, here is the updated icon set with the icon moved up slightly so that it's vertically centered.
Comment on attachment 8525527 [details]
patch for Gaia/master

Hey Peter,
can you check it again? :)
Attachment #8525527 - Flags: ui-review- → ui-review?(pla)
Comment on attachment 8525527 [details]
patch for Gaia/master

Hi Pavel,

The positioning of the icon looks good now.  The icon is still fuzzy but so are the other action icons - Amy Lee tells me there is a flag you have to pass in when loading the builds to render the @1.5x icons on Flame?
Attachment #8525527 - Flags: ui-review?(pla) → ui-review+
Attached image 2014-11-24-17-29-48.png (deleted) —
This is a screenshot of what it looks like for me (the fuzzy icons).
yep the flag is GAIA_DEV_PIXELS_PER_PX=1.5
Attachment #8525527 - Flags: review?(etienne)
Comment on attachment 8525527 [details]
patch for Gaia/master

Redirecting...
(but looking good!)
Attachment #8525527 - Flags: review?(etienne) → review?(drs.bugzilla)
Comment on attachment 8525527 [details]
patch for Gaia/master

I think we should be updating these as well:
https://github.com/mozilla-b2g/gaia/tree/master/apps/callscreen/style/images/shared
Attachment #8525527 - Flags: review?(drs.bugzilla) → review-
Attached image Screenshot of old icon still in use (deleted) —
Here's a screenshot of the place that the icon I referred to in comment 11 is used.
Hi Doug - yes I noticed that too afterwards.  I'll provide the icon for Pavel before we can close this bug.
(In reply to Peter La from comment #13)
> Hi Doug - yes I noticed that too afterwards.  I'll provide the icon for
> Pavel before we can close this bug.

Ok, thanks. Setting need info on you for that.
Flags: needinfo?(pla)
Attached file Icon for 'Call Ended' in 5 Sizes (deleted) —
Hi Doug/Pavel,

Please use this icon for the screen referred to in Comment 12.  I've included 5 sizes but use the sizes that are needed.  I don't think we technically need the 3.375x one yet.
Flags: needinfo?(pla)
Attachment #8525527 - Flags: review- → review?(drs.bugzilla)
Thanks Peter :)
Comment on attachment 8525527 [details]
patch for Gaia/master

Let's remove the images that are at 3.375x. We can include them later if needed.
Attachment #8525527 - Flags: review?(drs.bugzilla) → review-
Comment on attachment 8525527 [details]
patch for Gaia/master

Sure :) PR updated
Attachment #8525527 - Flags: review- → review?(drs.bugzilla)
Comment on attachment 8525527 [details]
patch for Gaia/master

Looks good, thanks.
Attachment #8525527 - Flags: review?(drs.bugzilla) → review+
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/b3a502115a00a191780893af6eca41b784761664
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: