Closed
Bug 1083625
Opened 10 years ago
Closed 10 years ago
Improve CSS for category drop-down on desktop
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-10-21
People
(Reporter: cvan, Assigned: cvan)
References
()
Details
The mocks unfortunately don't show the hover states: http://pwalm.github.io/marketplace-style-guides/navigation.html
But I think the hover states look a bit odd with the padding at the top and bottom of the nav and the lack of `border-radius` on the first two items and last two items:
https://www.dropbox.com/s/r3e8hwykhevm3kj/Screenshot%202014-10-15%2021.15.43.png?dl=0
Assignee | ||
Comment 1•10 years ago
|
||
Summary: Clean up CSS for category drop-down on desktop → Improve CSS for category drop-down on desktop
Assignee | ||
Comment 2•10 years ago
|
||
https://github.com/mozilla/fireplace/commit/b82520
––
QA: Please make sure that category drop-down on desktop (and categories page on mobile) looks okay, across multiple locales, sizes, platforms, devices.
Many thanks!
––
Tasks completed:
* simplify the CSS
* remove a bunch of unnecessary positioning changes upon hover
* remove the gap between the edges and add a `border-radius` to each nav item on the edge of the drop-down menu
Before:
![screenshot 2014-10-15 21 15 43](https://cloud.githubusercontent.com/assets/203725/4657734/fa7a66e0-54ef-11e4-913d-83aaadd47bd8.png)
After:
![screenshot 2014-10-16 12 57 32](https://cloud.githubusercontent.com/assets/203725/4669502/b0b1c1c8-556e-11e4-97cc-df1e6c5c7502.png)
––
Assignee: nobody → cvan
Status: NEW → RESOLVED
Closed: 10 years ago
Priority: -- → P3
Resolution: --- → FIXED
Target Milestone: --- → 2014-10-21
Comment 3•10 years ago
|
||
Verified as fixed in FF36(Win7) in marketplace-dev.allizom.org FFOS 1.4 and FFOS 2.1 and android 4.2.1
Postfix screencast: http://screencast.com/t/Jatx74NF6z5
Closing as fixed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•