Closed
Bug 1083651
Opened 10 years ago
Closed 10 years ago
[NFC] Remove unused error code
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: dimi, Assigned: dimi)
References
Details
(Whiteboard: [p=3])
Attachments
(2 files, 2 obsolete files)
NFC error code are defined in nfcd and gecko, some error code are useless and the meaning of the error code is unclear.
We should remove those error codes
|
Assignee | |
Comment 1•10 years ago
|
||
Since there are some nfcd pull request wait for review and merged.
I use git patch for review first. Once review is complete I will create another pull request
Attachment #8506752 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8506756 -
Flags: review?(allstars.chh)
Comment on attachment 8506752 [details] [diff] [review]
nfcd patch v1
Review of attachment 8506752 [details] [diff] [review]:
-----------------------------------------------------------------
::: src/MessageHandler.cpp
@@ +24,5 @@
> #include "SessionId.h"
> #include "NfcDebug.h"
>
> #define MAJOR_VERSION (1)
> +#define MINOR_VERSION (11)
The version is wrong.
It should have been 12.
Attachment #8506752 -
Flags: review?(allstars.chh)
Comment on attachment 8506756 [details] [diff] [review]
gecko patch v1
Review of attachment 8506756 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/nfc/gonk/NfcGonkMessage.h
@@ +7,5 @@
>
> namespace mozilla {
>
> #define NFCD_MAJOR_VERSION 1
> +#define NFCD_MINOR_VERSION 11
ditto.
Attachment #8506756 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8506756 -
Attachment is obsolete: true
Attachment #8507793 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8506752 -
Attachment is obsolete: true
Attachment #8507794 -
Flags: review?(allstars.chh)
Attachment #8507793 -
Flags: review?(allstars.chh) → review+
Attachment #8507794 -
Flags: review?(allstars.chh) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Whiteboard: [p=3]
Keywords: checkin-needed
|
||
Comment 10•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•