Closed Bug 1083989 Opened 10 years ago Closed 10 years ago

Global browser-test.js should not import Promise.jsm into global scope

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: Yoric, Assigned: Yoric)

References

Details

Attachments

(4 files, 2 obsolete files)

No description provided.
Attached patch 1. Removing Promise.jsm from the scope (obsolete) (deleted) — Splinter Review
I still need to check for any fallback.
Assignee: nobody → dteller
Attachment #8506956 - Flags: review?(ted)
Attached patch 2. Adapting devtools tests (obsolete) (deleted) — Splinter Review
Paul, could you review the devtools tests that I needed to adapt? Changes are rather straightforward.
Attachment #8512249 - Flags: review?(paul)
Attached patch 2. Adapting devtools tests (deleted) — Splinter Review
Sorry, that was the wrong patch.
Attachment #8512249 - Attachment is obsolete: true
Attachment #8512249 - Flags: review?(paul)
Attachment #8512250 - Flags: review?(paul)
Attached patch 3. Mochitest browser test (deleted) — Splinter Review
Trivial change to a single test, self-reviewing.
Attachment #8512251 - Flags: review+
Comment on attachment 8512250 [details] [diff] [review] 2. Adapting devtools tests Thanks a *lot* for that.
Attachment #8512250 - Flags: review?(paul) → review+
Attachment #8506956 - Flags: review?(ted) → review+
Hey Yoric, seems this patch didn't apply cleanly like: Hunk #2 succeeded at 582 with fuzz 1 (offset 4 lines). Hunk #4 FAILED at 956 1 out of 4 hunks FAILED -- saving rejects to file testing/mochitest/browser-test.js.rej patch failed, unable to continue (try -v) patch failed, rejects left in working dir errors during apply, please fix and refresh 1083989.diff could you please take a look? Thanks!
Flags: needinfo?(dteller)
Rebased.
Attachment #8506956 - Attachment is obsolete: true
Flags: needinfo?(dteller)
Attachment #8514201 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: