Closed
Bug 1083989
Opened 10 years ago
Closed 10 years ago
Global browser-test.js should not import Promise.jsm into global scope
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(4 files, 2 obsolete files)
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
I still need to check for any fallback.
Assignee: nobody → dteller
Attachment #8506956 -
Flags: review?(ted)
Assignee | ||
Comment 2•10 years ago
|
||
Checking for any fallback: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=53959a948acd
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Paul, could you review the devtools tests that I needed to adapt? Changes are rather straightforward.
Attachment #8512249 -
Flags: review?(paul)
Assignee | ||
Comment 5•10 years ago
|
||
Sorry, that was the wrong patch.
Attachment #8512249 -
Attachment is obsolete: true
Attachment #8512249 -
Flags: review?(paul)
Attachment #8512250 -
Flags: review?(paul)
Assignee | ||
Comment 6•10 years ago
|
||
Trivial change to a single test, self-reviewing.
Attachment #8512251 -
Flags: review+
Comment 7•10 years ago
|
||
Comment on attachment 8512250 [details] [diff] [review]
2. Adapting devtools tests
Thanks a *lot* for that.
Attachment #8512250 -
Flags: review?(paul) → review+
Updated•10 years ago
|
Attachment #8506956 -
Flags: review?(ted) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Hey Yoric,
seems this patch didn't apply cleanly like:
Hunk #2 succeeded at 582 with fuzz 1 (offset 4 lines).
Hunk #4 FAILED at 956
1 out of 4 hunks FAILED -- saving rejects to file testing/mochitest/browser-test.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 1083989.diff
could you please take a look? Thanks!
Flags: needinfo?(dteller)
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 9•10 years ago
|
||
Rebased.
Attachment #8506956 -
Attachment is obsolete: true
Flags: needinfo?(dteller)
Attachment #8514201 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/762aff2c9dbf
https://hg.mozilla.org/integration/mozilla-inbound/rev/27e644701c98
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e406b1536f9
Flags: in-testsuite+
Keywords: checkin-needed
Comment 11•10 years ago
|
||
Unfortunately this had mochitest-e10s failures. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1955735d5cdc
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3438561&repo=mozilla-inbound
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3439556&repo=mozilla-inbound
Assignee | ||
Comment 12•10 years ago
|
||
Trivial patch for e10s
https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/
Attachment #8514840 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 13•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/09fbfd40895a
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2df2cbac90f
https://hg.mozilla.org/integration/mozilla-inbound/rev/02c42f877b1b
https://hg.mozilla.org/integration/mozilla-inbound/rev/85aa67127933
Keywords: checkin-needed
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/09fbfd40895a
https://hg.mozilla.org/mozilla-central/rev/c2df2cbac90f
https://hg.mozilla.org/mozilla-central/rev/02c42f877b1b
https://hg.mozilla.org/mozilla-central/rev/85aa67127933
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•