Closed
Bug 1084302
Opened 10 years ago
Closed 10 years ago
nsGtkIMModule::DeleteText() calls DispatchCompositionChangeEvent() with wrong argument
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: inputmethod)
Attachments
(1 file)
|
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
The definition of nsGtkIMModule::DispatchCompositionChangeEvent() is:
bool nsGtkIMModule::DispatchCompositionChangeEvent(
const nsAString &aCompositionString,
bool aIsCommit);
The second argument should be true when it's called for committing composition string (i.e., immediately before dispatching compositionend).
Otherwise, i.e., the composition string should be still being composed, it should be false.
However, DeleteText() sends false for the former purpose and true for the latter purpose.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8506784 -
Flags: review?(karlt)
|
|
Assignee | |
Comment 2•10 years ago
|
||
FYI: I cannot test it because I don't know the actual case which is used.
|
||
Updated•10 years ago
|
Attachment #8506784 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•