Closed Bug 1084353 Opened 10 years ago Closed 10 years ago

[Loop] I can't see the ID of the contact in the Call Log when I call, via browser, from a link shared by that contact in a SMS/e-mail

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

ARM
Gonk (Firefox OS)
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: lolimartinezcr, Unassigned)

References

Details

(Whiteboard: [mobile app][Test-Run1][blocking][tef-triage])

Attachments

(2 files)

Attached image 2014-10-17-13-45-06.png (deleted) —
fireE (firee-kk-v2.0-SW2E3-1) Loop version: 1.1 , 2168965 Pre-requisites: Device A has a contact saved with name and phone number. Device B has a contact saved with name and phone number. Device B isn't logged in Loop STRs: 1. Device A make a video call since call log to device B. 2. After seconds, device A shares link via Message to device B. For this, user (in device A) taps in Message button and sends it -> Result: Device B receives a message with link share. 3. Device B is logged in Loop. 4. User (in device B) taps in message application and taps in link shared and received. -> Result: Device B opens browser with "Firefox Hello". 5. User (in device B) taps in "Start" button in browser. 6. Device A answers video call 7. After some seconds, device A hangs up video call Actual result: In device B , in "Calls" tab I can't see the ID of the contact. Expected result: In device B , in "Calls" tab I can see the ID of the contact.
Blocks: 1036490
Whiteboard: [mobile app][Test-Run1]
Just adding that, I am also reproducing this error, and what I expect to see is the name of the contact (no the ID) and right now nothing is shown in device B. The A contact name is not shown in the call log of device B and is also not shown in the call screen of Device B when the call is stablished (before hanging up)
Summary: [Loop] In "Calls" tab I can't see the ID of the contact when I call since link received in a message. → [Loop] I can't see the ID of the contact In "Calls" tab and the Call screen when I call, via browser, from a link shared by that contact in a SMS/e-mail
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Severity: normal → major
Whiteboard: [mobile app][Test-Run1] → [mobile app][Test-Run1][blocking][tef-triage]
Attached file Github pull request (deleted) —
After talking with Fernando we have two issues here: 1) Server side: we are not receiving the identities in the call object. This should be fixed in the server 2) Obviously if we don't receive this info, we won't be able to identify the recipient so we have to show "Unknown" which is a string defined in l10n properties instead of nothing This patch implements the point 2.
Attachment #8508514 - Flags: review?(ferjmoreno)
Comment on attachment 8508514 [details] Github pull request LGTM
Attachment #8508514 - Flags: review?(ferjmoreno) → review+
This patch shows "Unknown" when we are not able to identify neither the contact nor identities. in master: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/2c16168f2d8337fbd9fa34ee62d262b9e1260835
Fernando, should we close it once bug 1086698 is landed?
Flags: needinfo?(ferjmoreno)
(In reply to Cristian Rodriguez (:crdlc) from comment #5) > Fernando, should we close it once bug 1086698 is landed? Yes, let's wait for bug 1086698 landing so QA team can verify this issue properly
Flags: needinfo?(ferjmoreno)
Assignee: crdlc → nobody
No longer blocks: 1086698
Depends on: 1086698
After landing server patch, bug 1086698 in dev Loop server, I have seen that the contact/user ID is shown correctly in the call log of Device B, after clicking the shared URL, but in the established call I was not able to see the contact/user ID in the call screen of B device... perhaps there is an issue on client side as server seems work as expected. Cristian, what do you think?
Flags: needinfo?(crdlc)
it should be fixed in another bug, we can close this once server will have the new change
Flags: needinfo?(crdlc)
(In reply to Cristian Rodriguez (:crdlc) from comment #8) > it should be fixed in another bug, we can close this once server will have > the new change Ok, I've opened bug 1090849 to handle the Call screen issue. We are not closing this bug 1084353, until bug 1086698 is in Production so QA team can verify it properly.
Summary: [Loop] I can't see the ID of the contact In "Calls" tab and the Call screen when I call, via browser, from a link shared by that contact in a SMS/e-mail → [Loop] I can't see the ID of the contact in the Call screen when I call, via browser, from a link shared by that contact in a SMS/e-mail
Summary: [Loop] I can't see the ID of the contact in the Call screen when I call, via browser, from a link shared by that contact in a SMS/e-mail → [Loop] I can't see the ID of the contact in the Call Log when I call, via browser, from a link shared by that contact in a SMS/e-mail
Changed my mind, let's resolve it and QA team will verify it when bug 1086698 is in Production.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified on Flame & FireE, loop version 1.1: 2e7c3c2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: