Daniel Holbert [:dholbert] Reporter
	Description • 10 years ago

I just did a (non-clobber) build with up-to-date mozilla-central (cset 51892b39597a).

At the end of my build, I got 12 copies of this line:
> Warning: missing module: resource://gre/modules/AddonManager.jsm

...and 18 copies of this line:
> Warning: missing module: ../../framescript/FrameScriptManager.jsm

These warnings were intermixed with the "Exporting extension to [whatever].xpi" lines, so I guess they're generated by that part of the build process.

I don't know what's causing these, but I think this is a pretty recently-introduced problem -- I haven't noticed this before.  Can we fix it whatever's causing this?

(Not sure where this bug belongs. Starting it off in Toolkit|Add-on SDK, since that's where AddonManager.jsm was last touched.)

	Daniel Holbert [:dholbert] Reporter
	Comment 1 • 10 years ago

I'm attaching the end of my build log, with these warnings in context.

	Dave Townsend [:mossop]
	Comment 2 • 10 years ago

It's outputted as part of cfx building the test add-ons for the SDK.

Erik or Zombie, any reason we can't turn off these warnings in cfx?

	Tomislav Jovanovic :zombie Assignee
	Comment 3 • 10 years ago

the warning was intentional as an intermediary step toward jpm, but i think we can safely turn off for .jsm modules..

	Tomislav Jovanovic :zombie Assignee
	Comment 4 • 10 years ago

hey Erik, does it make sense to add JSM modules to `requirements`?

up until sdk 1.16 we didn't (we couldn't), then starting with 1.17 we did (by accident), without any noticeable difference.

so since it doesn't matter, i decided not to..

	Erik Vold [:erikvold] (please needinfo? me)
	Comment 5 • 10 years ago

Comment on attachment 8541865 [details]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1773

We aren't releasing a new version of cfx, but I'm ok with merging this.

	[github robot]
	Comment 6 • 10 years ago

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/c32cc66d95dd951bbd647c60ad2888a19b430a8f
bug 1084489 - don't warn on JSM modules

https://github.com/mozilla/addon-sdk/commit/37d9388358a913e83828432e19f2534b0e321c50
Merge pull request #1773 from zombie/1084489-jsm-warn

bug 1084489 - don't warn on JSM modules, r=@erikvold

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 7 • 10 years ago

I still get a lot of these warnings while building Nightly. zombie, would you like more details? Should we reopen this bug?

	Dave Townsend [:mossop]
	Comment 8 • 10 years ago

(In reply to Liz Henry :lizzard from comment #7)
> I still get a lot of these warnings while building Nightly. zombie, would
> you like more details? Should we reopen this bug?

The bug is fixed in the Add-on SDK github repo. It will not be fixed in mozilla-central until the next uplift.