Closed Bug 1084696 Opened 10 years ago Closed 10 years ago

Use our RAII helper to unlock DrawTarget bits after locking

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file)

0001-Actually-use-the-RAII-helper-for-locking.patch
(deleted), patch
u480271
: review+
Details | Diff | Splinter Review
I made a nice little RAII helper for unlocking: AutoLockBits I defined it in a function...and then used the normal LockBits() call instead of the RAII version. No unlock call appears to be made. This might be the cause of bug 1081790.
Attachment #8507319 - Flags: review?(matt.woodrow)
Comment on attachment 8507319 [details] [diff] [review] 0001-Actually-use-the-RAII-helper-for-locking.patch Review of attachment 8507319 [details] [diff] [review]: ----------------------------------------------------------------- Or Dan.
Attachment #8507319 - Flags: review?(matt.woodrow) → review?(dglastonbury)
Attachment #8507319 - Flags: review?(dglastonbury) → review+
https://hg.mozilla.org/mozilla-central/rev/cbce7c288e53 https://hg.mozilla.org/mozilla-central/rev/44c69e5c99fc
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: