Closed
Bug 1085162
Opened 10 years ago
Closed 10 years ago
Expose isOfficial in fake telemetry appinfo
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
Details
Attachments
(1 file)
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Via bug 1085146 i noticed that we use a fake appinfo in test_TelemetryPing.jsm, which means that we can't actually use appinfo.isOfficial (meaning we skip a check).
A better approach would probably be to use AppInfo.jsm later and make that work properly for properties that are not overridden.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → georg.fritzsche
Assignee | ||
Comment 1•10 years ago
|
||
One possible approach: just use the original appinfo as the prototype of the fake appinfo (so we just get the original values for everything we don't overwrite).
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=199be957793e
https://tbpl.mozilla.org/?tree=Try&rev=199be957793e
Attachment #8507555 -
Flags: review?(nfroyd)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8507555 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
sorry had to backout this cset in https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=2a037ad0ab7a since this or the other bug caused test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3164441&repo=mozilla-inbound
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•