Closed Bug 1085162 Opened 10 years ago Closed 10 years ago

Expose isOfficial in fake telemetry appinfo

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

Attachments

(1 file)

Via bug 1085146 i noticed that we use a fake appinfo in test_TelemetryPing.jsm, which means that we can't actually use appinfo.isOfficial (meaning we skip a check). A better approach would probably be to use AppInfo.jsm later and make that work properly for properties that are not overridden.
Assignee: nobody → georg.fritzsche
One possible approach: just use the original appinfo as the prototype of the fake appinfo (so we just get the original values for everything we don't overwrite). https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=199be957793e https://tbpl.mozilla.org/?tree=Try&rev=199be957793e
Attachment #8507555 - Flags: review?(nfroyd)
Status: NEW → ASSIGNED
Depends on: 1073536
Attachment #8507555 - Flags: review?(nfroyd) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: