Closed
Bug 1085290
Opened 10 years ago
Closed 10 years ago
[Bluetooth][Settings] Support version detection for Bluetooth module/panel between v1/v2 API
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(tracking-b2g:+)
People
(Reporter: iliu, Assigned: iliu)
References
Details
Attachments
(1 file)
This bug will support version detection for v1/v2 API. And will create a new Bluetooth panel to leave the old code base.
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → 2.1 S7 (24Oct)
Assignee | ||
Comment 1•10 years ago
|
||
Arthur, per offline discussion, we separate the version detection and new panel implementation from bug 1070823. This patch is arming to complete as description. And ensure we won't load useless module on incorrect API version. Could you please help to review my pull request? And I will keep to add unit test. Thanks.
Attachment #8507795 -
Flags: review?(arthur.chen)
Comment 2•10 years ago
|
||
Comment on attachment 8507795 [details]
pull request 25320
Most of the code looks good to me, please check my comments in github, thanks!
Attachment #8507795 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8507795 [details]
pull request 25320
Arthur, I have updated the patch. And add some unit test to cover these change. Thanks for guiding 'Promise' usage. That is very useful for async call. Will need your review again.
Addition:
* Dynamically load modules/bluetooth_v? via version detection.
* Use Promise to get Bluetooth module.
Attachment #8507795 -
Flags: review?(arthur.chen)
Comment 4•10 years ago
|
||
Comment on attachment 8507795 [details]
pull request 25320
Looks much better now. Please check my comments in github, thanks.
Attachment #8507795 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8507795 [details]
pull request 25320
Already updated the patch with your suggestion. Thanks for the reviewing effort.:)
Attachment #8507795 -
Flags: review?(arthur.chen)
Comment 6•10 years ago
|
||
Comment on attachment 8507795 [details]
pull request 25320
r=me with the last comments addressed, thanks!
Attachment #8507795 -
Flags: review?(arthur.chen) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Updated the patch for last comments address. And will land the pr after pass all test on try-server.
Assignee | ||
Comment 8•10 years ago
|
||
Since passed on try-server and landed, we can close the issue now.
Gaia/master: da95f7d329bc1cbd523a2439edf171f082809e1b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
tracking-b2g:
--- → +
You need to log in
before you can comment on or make changes to this bug.
Description
•