In bug 1083745, we would like to deprecate IccCardLockError.lockType. But Gaia gets lockType from IccCardLockError now, like https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/simcard_dialog.js#L95-L128. let request = icc.unlockCardLock(lockType); request.onerror = function(evt) { lockType = evt.target.error.lockType; .... }; Actually the |evt.target.error.lockType| is just the same as the lockType passed by caller. We could simply rewrite the code as below, let request = icc.unlockCardLock(lockType); request.onerror = function(lockType, evt) { ..... }.bind(this, lockType); Thank you.

Edgar, what's the schedule for you to remove this lockType from Gecko ? I can take this first.

This bug blocks bug 1052825 which is a v2.2 P1 item for telephony team. I can help to take cover this if you don't have free buffer to do this. :) Thank you.

Sure Edgar, based on our offline discussion, let me redirect this bug to you first. Thanks !

Comment on attachment 8509155 [details] [mozilla-b2g:master] PR #25371 Hi EJ, may I have your review on Setting part?

Comment on attachment 8509155 [details] [mozilla-b2g:master] PR #25371 Hi Alive, may I have your review on System part? Thank you

Comment on attachment 8509155 [details] [mozilla-b2g:master] PR #25371 Hi sfoster, may I have your review for FTU part? Thank you.

Comment on attachment 8509155 [details] [mozilla-b2g:master] PR #25371 +system part

Comment on attachment 8509155 [details] [mozilla-b2g:master] PR #25371 FTU part looks good to me. Looks like we have no test coverage for the retryCount property in the error in the FTU, I'm making a note to add that but its backfill and not necessary to land this.

Comment on attachment 8509155 [details] [mozilla-b2g:master] PR #25371 r+ for settings part. Thanks Edgar !!

Thanks to all of you for the review.

treeherder result looks good: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=db6d2c204673

master: https://github.com/mozilla-b2g/gaia/commit/bfbd561aff39154d65ef9891ce3f8bc9e9c5e44c