Closed
Bug 1085704
Opened 10 years ago
Closed 10 years ago
dzAlerts should link to Treeherder instead of TBPL
Categories
(Datazilla Graveyard :: Metrics, defect)
Datazilla Graveyard
Metrics
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
https://github.com/klahnakoski/datazilla-alerts/search?utf8=%E2%9C%93&q=tbpl.mozilla.org&type=Code
Note the repo names are different to TBPL - they actually match the buildbot 'branch' now. See the "name" property in:
https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/fixtures/repository.json
Assignee | ||
Comment 1•10 years ago
|
||
This roughly switches over to linking to Treeherder (the PR is against the dev branch, not sure if that was the right one), but I was slightly confused by dzAlerts/daemons/sustained_median.py - it looks incomplete?
Attachment #8536256 -
Flags: review?(klahnakoski)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
I admit the dzAlerts/daemons/sustained_median.py has not been tested on the Treeherder data yet: If there are any changes, they should be small because the import routine is mimicking the import from Datazilla.
Please ask questions about the code: I am more than happy to refactor it into more coherent individual modules both for you, me, and individual contributors. My objective for this quarter is to improve the contributor score [1], so I am organizing now.
Thanks
[1] https://wiki.mozilla.org/Auto-tools/Projects#Guidelines
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Kyle Lahnakoski [:ekyle] from comment #2)
> I admit the dzAlerts/daemons/sustained_median.py has not been tested on the
> Treeherder data yet: If there are any changes, they should be small because
> the import routine is mimicking the import from Datazilla.
Sorry I should have clarified - by "incomplete" I meant that I could find where we were setting the values used in the template, so it looked like the template code was unused (for sustained_median.py only). Either way the PR should update the links ok for now - thank you for merging :-)
https://github.com/klahnakoski/datazilla-alerts/commit/87beec0a0ad68a54ae287170d22eae2afb02bbbb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Attachment #8536256 -
Flags: review?(klahnakoski)
You need to log in
before you can comment on or make changes to this bug.
Description
•