Closed
Bug 1085719
Opened 10 years ago
Closed 10 years ago
bzpost should link to Treeherder instead of TBPL
Categories
(Developer Services :: Mercurial: bzpost, defect)
Developer Services
Mercurial: bzpost
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/749] )
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/hgcustom/version-control-tools/file/66ec32ebac13/hgext/bzpost/__init__.py#l94
https://hg.mozilla.org/hgcustom/version-control-tools/file/66ec32ebac13/hgext/bzpost/__init__.py#l149
Note the repo names are different to TBPL - they actually match the buildbot 'branch' (and repo directory name) now. See the "name" property in:
https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/fixtures/repository.json
|
||
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/298]
|
|
||
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/298] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/749] [kanban:engops:https://kanbanize.com/ctrl_board/6/298]
|
||
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/749] [kanban:engops:https://kanbanize.com/ctrl_board/6/298] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/749]
|
Assignee | |
Comment 1•10 years ago
|
||
Now that mozautomation has a new treeherder_url(), bzpost should use that,
rather than reimplementing itself. In addition, we want bzpost to link to
Treeherder, rather than TBPL, which this also achieves.
Attachment #8536802 -
Flags: review?(gps)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
I should add that this is rebased on bug 1085723. Also the newline additions in the file are to fix a few flake8 warnings.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Now with the tests updated too.
Attachment #8536806 -
Flags: review?(gps)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8536802 -
Attachment is obsolete: true
Attachment #8536802 -
Flags: review?(gps)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8536806 [details] [diff] [review]
bzpost: use treeherder_url() for Try URLs generation
Review of attachment 8536806 [details] [diff] [review]:
-----------------------------------------------------------------
You rock!
Attachment #8536806 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•10 years ago
|
||
|
|
Assignee | |
Comment 7•10 years ago
|
||
Thanks for the fixup :-)
|
|
Assignee | |
Comment 8•10 years ago
|
||
(In reply to Ed Morley (away until 3rd Jan) [:edmorley] from comment #7)
> Thanks for the fixup :-)
Meant to say, I did watch the CI, but it turns out I was watching https://ci.mozilla.org/job/version-control-tools/379/ , which wasn't due to my push, but triggered by timer shortly before it (and Jenkins seems to not trigger another whilst the first is in progress), so I was actually seeing the results of prior to my changes, doh.
You need to log in
before you can comment on or make changes to this bug.
Description
•