Closed Bug 108626 Opened 23 years ago Closed 23 years ago

PSM must handle more SSL_ERRORs

Categories

(Core Graveyard :: Security: UI, defect, P2)

1.0 Branch
x86
Windows 2000
defect

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 107491
psm2.2

People

(Reporter: ssaux, Assigned: KaiE)

Details

In nsNSSIOLayer::nsHandleSSLError() we only handle a few of the errors defined in sslerr.h Some of the errors we should clearly handle are: 74 SSL_ERROR_REVOKED_CERT_ALERT = (SSL_ERROR_BASE + 18), 75 SSL_ERROR_EXPIRED_CERT_ALERT = (SSL_ERROR_BASE + 19), So that we can do correct validation when doing client auth. See NSS bug 108250. Now there are 102 SSL_ERRORs. Would it make sense to cover them all? One way to do that is to remove the case statememt from the nsHandleSSLError and store strings for all the errors in the string bundle based on the error number (something like SSLError12269 would be the index for -12269). Note that we can use the strings stored in SSLerrs.h for the error strings (for the en-US locale.
This bug appears to be entirely a duplicate of bug 107491, which is already assigned at P2 to rangansen. IMO, ALL the SSL and SEC errors (in other words, all the NSS errors) should be handled by PSM and localized properly.
*** This bug has been marked as a duplicate of 107491 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Priority: -- → P2
Resolution: --- → DUPLICATE
Target Milestone: --- → 2.2
Verified dupe.
Status: RESOLVED → VERIFIED
Product: PSM → Core
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.