doctor__j Reporter
	Description • 23 years ago

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.5+) Gecko/20011029
BuildID:    2001102906

Reproducible: Always

Steps to Reproduce:
1. Load the testcase.
2. Right-click on the textbox.
3. See the long and incorrect menu items shown.

	rods (gone)
	Comment 3 • 23 years ago

over to kin for triage

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 23 years ago

I see no context menu there at all on current linux.  Blake?

	Madhur Bhatia
	Comment 5 • 23 years ago

wfm on win2000 buildID: 2001-11-06-03 trunk build.

	doctor__j Reporter
	Comment 6 • 23 years ago

Now I can't see the context menu popping up at all !!
(using Win32 trunk build 2001110803)

	Matthias Versen [:Matti]
	Comment 8 • 23 years ago

confirming with win2k build 20011108.. (CVS opt and debug)
The context menu is dead for textfields and I get the same JS errors: 
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=57036
Madhur: 
Try it with a recent build in a URL field of a bug.
(It works in the comment field)

kin: Can you try to fix this for 0.9.6 ?

	kinmoz Assignee
	Comment 9 • 23 years ago

I'm putting it in 0.9.7, but I'll look into it asap.

	kinmoz Assignee
	Comment 10 • 23 years ago

This was caused by the JS Null string landing. We can no longer take shortcuts
like:

   node.getAttribute("foo").toUpperCase();

because getAttribute() now returns null instead of an empty string when "foo"
doesn't exist as an attribute. Blake, you'll probably want to do a sweep
through some of the browser JS files and make sure this isn't being done else
where ... we already went through this exercise in Composer.

Can I get an r= and sr= from blake and jst?

I'd like to get this in for 0.9.6 if possible.

	kinmoz Assignee
	Comment 11 • 23 years ago

Changing summary from:

  Very long and incorrect context menu is shown when right-clicking on textbox.

to:

  No context menu when right clicking on form text widgets

	Johnny Stenback (:jst)
	Comment 12 • 23 years ago

Comment on attachment 57649 [details] [diff] [review]
Patch Rev 1

sr=jst

	Blake Ross
	Comment 13 • 23 years ago

Comment on attachment 57649 [details] [diff] [review]
Patch Rev 1

r=blake

	kinmoz Assignee
	Comment 14 • 23 years ago

Checked in fix on trunk:

  mozilla/xpfe/communicator/resources/content/nsContextMenu.js  revision 1.44

I'm going to leave this bug open for now in hopes that I can land it on the
0.9.6 branch.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 15 • 23 years ago

a=roc+moz for 0.9.6

	kinmoz Assignee
	Comment 16 • 23 years ago

Checked in fix on MOZILLA_0_9_6_BRANCH:

  mozilla/xpfe/communicator/resources/content/nsContextMenu.js  revision 1.43.2.1

	Madhur Bhatia
	Comment 17 • 23 years ago

verified fixed in trunk build : 2001-11-09-06trunk -- win2000

	Madhur Bhatia
	Comment 18 • 23 years ago

sorry ...... that is build ID: 2001-11-19-06trunk on win2000

	Madhur Bhatia
	Comment 19 • 23 years ago

marking verified fixed in win2000 branch build : 2001-11-20-03-0.9.6