:Margaret Leibovic Reporter
	Description • 10 years ago

It was designed to match our old old toolbar theme, let's update it!

If we get some basic designs, I can mentor this bug. This is low priority, but I think it would be a really nice brand touch, especially since we ship about:firefox as a default bookmark, and link to it from settings.

	Anthony Lam (:antlam) Find me, @antlam on Slack!
	Comment 1 • 10 years ago

Agree! Leaving NI on for now.

	Anthony Lam (:antlam) Find me, @antlam on Slack!
	Comment 2 • 9 years ago

I did a quick pass using our current colors, styles, etc. I think this is a good place to start. This inherits a lot of styles from our other about pages as well to provide more consistency.

Notes: 
 - "What's new?" is a placeholder for a future idea, we can stick to "Release notes" for now
 - The app icon is used at the top so we can reuse that asset
 - The heart at the footer can be taken from our about:feedback page

	Anthony Lam (:antlam) Find me, @antlam on Slack!
	Comment 3 • 9 years ago

Quick specs: (more to come later)
 - Blue area (link blue #0096DD) is 180px tall
 - Each list item is 70 px tall
 - List item labels are 24px from the left (#363B40, Clear sans regular, 16px)
 - 1px divider after each list item (#D7D9DB)

	obongofon
	Comment 4 • 9 years ago

Hello, can you assign me this bug for me to fix. Thanks

	:Margaret Leibovic Reporter
	Comment 5 • 9 years ago

(In reply to obongofon from comment #4)
> Hello, can you assign me this bug for me to fix. Thanks

Hi there! We're happy you're interested in taking on this bug. In general, we don't like to assign bugs until people start working on patches for them, so feel free to go ahead and start a patch, then we can assign the bug to you once you've attached a patch for feedback/review.

Do you have a build environment set up? If not, you'll want to check out the instructions here:
https://wiki.mozilla.org/Mobile/Fennec/Android

Feel free to join #mobile on irc.mozilla.org if you're running into any trouble and need help.

	Ray Lin[:ralin]
	Comment 6 • 9 years ago

Hi, I'd like to take this bug. Is the spec still up to date? Thanks!

	Vance Chen [:vchen][skype:vance.lucida][vchen@mozilla.com]
	Comment 7 • 8 years ago

ni Anthony per Comment#6

	Anthony Lam (:antlam) Find me, @antlam on Slack!
	Comment 8 • 8 years ago

(In reply to Ray Lin[:ralin] from comment #6)
> Hi, I'd like to take this bug. Is the spec still up to date? Thanks!

Yep!

	Ray Lin[:ralin]
	Comment 9 • 8 years ago

Hi, Anthony

Could you give me some feedback about this screenshot? 
Thanks

btw, a couple notes:
- Old page seems to have more detail about version number including build date, do we need to retain all information?
- update button is optional for it could be disabled at build time. However, I think we should just hide it.
- Some title changes in the list will touch the l10n area, so I prefer keep original string unless necessary.

	Anthony Lam (:antlam) Find me, @antlam on Slack!
	Comment 10 • 8 years ago

(In reply to Ray Lin[:ralin] from comment #9)
> Created attachment 8757156 [details]
> about.png
> 
> Hi, Anthony
> 
> Could you give me some feedback about this screenshot? 
> Thanks

Nice work Ray! this is looking really good. It's coming along well.

Some feedback:
 - Check for updates button: 
 -- the text is not vertically aligned. Can we center it in the button?
 - Build icon looks blurry - what size is this? it seems like it might be getting stretched too large.
 - The heart icon - it looks skewed. I just reused the asset from bug 1175375. Is that the one you're using too?
 - Pressed state - background should be #F5F5F5 when these list items are pressed.

> btw, a couple notes:
> - Old page seems to have more detail about version number including build
> date, do we need to retain all information?

Yes, you bring up a good point. I think that was left out of the design. So, I'll have a look at where we can add that back.

> - update button is optional for it could be disabled at build time. However,
> I think we should just hide it.

The "check for updates" button? Yes, we can just hide it. Then, the "Firefox 99" and the build icon will need to remain centered. I'll attach a screenshot.

> - Some title changes in the list will touch the l10n area, so I prefer keep
> original string unless necessary.

Ok, that's a fair point. I added the "Brought to you by the people of Mozilla" at the footer though, so we might need to remove that.

thanks Ray!

	Anthony Lam (:antlam) Find me, @antlam on Slack!
	Comment 11 • 8 years ago

^ as per above.

	Ray Lin[:ralin]
	Comment 12 • 8 years ago

Thank you Anthony.

I've update the patch.

- The text in check for updates button is set to vertical center. However, the last char of "Check for Updates »" looks little lower than average.
- The size of icon is 64 * 64px took from "branding/[release branch]/content/favicon64.png", and set as 64 * 64px. It looks like the images had been lossy compressed. (to reduce size?)
- heart icon is set to original aspect ratio now.
- new rules for pressed on list are added.

A new screenshot will be attached later, I'm on tweaking some details.

	Ray Lin[:ralin]
	Comment 13 • 8 years ago

per comment 12

The icon size used in last screenshot is 384x384 from https://dxr.mozilla.org/mozilla-central/source/browser/branding/official/content/about-logo%402x.png
No blur but could gain 79kb to the package size.

remove the text and make the heart icon be centered in the bottom.

	apoorvasingh2811
	Comment 14 • 7 years ago

Hi, can I take this up?

	Ray Lin[:ralin]
	Comment 15 • 7 years ago

(In reply to apoorvasingh2811 from comment #14)
> Hi, can I take this up?

Hi! I'm not the mentor, but I think comment 5 may help :D

	Firefox Bug Husbandry Bot
	Comment 16 • 6 years ago

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

	irina6793
	Comment 17 • 6 years ago

Hi, can I take this one?
Please let me know.
Thank you

	Yatri
	Comment 18 • 6 years ago

Hey,

I would like to work on this as my second bug. I'm also willing to do Outreachy in Mozilla, so this will help me get familiar with code base!

Thanks

	qwertyravi86
	Comment 19 • 6 years ago

Assign this to me