Joe Walker [:jwalker] Reporter
	Description • 10 years ago

      No description provided.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 1 • 10 years ago

These are the strings I need for bug 1086936.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 2 • 10 years ago

Bug 1086936 contains some screenshots that show where the strings will appear.

	Francesco Lodolo [:flod]
	Comment 3 • 10 years ago

Comment on attachment 8509478 [details] [diff] [review]
v1

Review of attachment 8509478 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/preferences/main.dtd
@@ +37,5 @@
>  <!ENTITY setAsMyDefaultBrowser.accesskey  "D">
>  <!ENTITY isDefault.label                  "&brandShortName; is currently your default browser">
>  <!ENTITY isNotDefault.label               "&brandShortName; is not your default browser">
>  
> +<!ENTITY separateProfileMode.label        "Allow &brandShortName; to run at the same time as Firefox using a separate profile">

Someone with proper copy/UI skills should review this.

Personally I think that the "use a separate profile" should be the first bit of the sentence. And if we disable/ignore the profile manager, we should explain it too.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 4 • 10 years ago

Update based on shorlander's suggestions.

	Francesco Lodolo [:flod]
	Comment 5 • 10 years ago

Comment on attachment 8510069 [details] [diff] [review]
v2

Review of attachment 8510069 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/preferences/main.dtd
@@ +37,5 @@
>  <!ENTITY setAsMyDefaultBrowser.accesskey  "D">
>  <!ENTITY isDefault.label                  "&brandShortName; is currently your default browser">
>  <!ENTITY isNotDefault.label               "&brandShortName; is not your default browser">
>  
> +<!ENTITY separateProfileMode.label        "Keep &brandFullName; data separate from Firefox data">

As commented in the other bug, &brandFullName; means "Firefox for Developers" for all locales, and that's just awful.

"FirefoxDevEdition" is not great, but at least it sounds like a code name (Aurora, Nightly, Beta) and I can live with that.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 6 • 10 years ago

(In reply to Francesco Lodolo [:flod] from comment #5)
> As commented in the other bug, &brandFullName; means "Firefox for
> Developers" for all locales, and that's just awful.

Actually, once I upload a new version of the branding patch in bug 1072181, it will be "Firefox Developer Edition" as Stephen suggests.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 7 • 10 years ago

Actually I don't need the accesskey since I'm now using a link instead of a button.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 8 • 10 years ago

Updated per Matej's suggestions in bug 1086936 comment 23.

	Francesco Lodolo [:flod]
	Comment 9 • 10 years ago

It could be just me, but having two separate bugs like this is making the conversation quite hard to follow.

What about just one bug, two patches and leave-open keyword? Especially considering there are more string changes discussed in bug 1086936

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 10 • 10 years ago

Yeah, this was a practice that made sense in the rush before branching aurora, but it seems pointless now. I've already asked Joe about folding the patches together.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 11 • 10 years ago

Joe agrees that we should fold this patch back into bug 1086936.