Yuying Long Reporter
	Description • 23 years ago

Build: 11-06 trunk build

If you go View | Character Coding | More, you will find there are 2 extra 
charsets - iso-8859-16 and Korean (ISO-2022-KR) compare to N6.2 RTM build, and
we never had these 2 charsets there before.

Should they go to West European and East Asian category?

	Roy Yokoyama Assignee
	Comment 2 • 23 years ago

We checked in the support for ISO-8859-16 on Oct 16th
and ISO-2022KR on Oct 13th.When do you start seeing this problem?

	Roy Yokoyama Assignee
	Comment 3 • 23 years ago

I LXR'ed it and found nothing changed so far.
http://lxr.mozilla.org/seamonkey/search?string=iso-2022-kr

	Yuying Long Reporter
	Comment 4 • 23 years ago

I'm not sure, since we were doing most test on branch build during the past
month.  But I noticed it last week.

	Roy Yokoyama Assignee
	Comment 5 • 23 years ago

I just pulled a new build and created a new Profile.
Korean (ISO-2022-KR) menu showed up under East Asian submenu 
(as it should be) However, ISO-8859-16 still shows under
More menu.

Then I added a 'ISO-8859-16' entry under intl.charsetmenu.browser.more1
in navigator.properties; but it still have the same problem.

	Roy Yokoyama Assignee
	Comment 6 • 23 years ago

My bad:
I added a 'iso-8859-16' entry instead of 'ISO-8859-16'in navigator.properties.
It's case sensitive!!!!! (not sure why....) 
Now, it shows as 'ISO-8859-16' under More menu.

What's a proper name for this?
Others say 'Western(ISO-8859-1)' and 'Greek(ISO-8859-7)'......

	Roy Yokoyama Assignee
	Comment 7 • 23 years ago

I think it should be "Romanian (ISO-8859-16)" under East European menu.

http://www.isi.edu/in-notes/iana/assignments/character-set-info/iso-8859-16
"ISO 8859-16 was primarily designed for single-byte encoding the Romanian
  language....... "

	Roy Yokoyama Assignee
	Comment 10 • 23 years ago

nhotta: can you review?

	nhottanscp
	Comment 11 • 23 years ago

Comment on attachment 56783 [details] [diff] [review]
Adding ISO-8859-16 in navigator.properties

r=nhotta

Please investigate why only ISO-8859-16 has to be uppercase.

	nhottanscp
	Comment 12 • 23 years ago

Comment on attachment 56782 [details] [diff] [review]
Adding Romanian (ISO-8859-16) in charsetTitles.properties

r=nhotta

	jbetak@netscape.com (away - not reading bugmail)
	Comment 13 • 23 years ago

>Please investigate why only ISO-8859-16 has to be uppercase.

I think I know why - you need to add it to charsetalias.properties. I was 
trying to get rid of this "aliasing" annoyance for the sake of improved 
performance but Frank stopped my zeal by correctly pointing out that we would 
most likely not want to deal with all the conceivable nasty regressions given 
our aggressive release schedule.

I still believe charset aliasing should be eliminated whenever time permits it, 
but for the sake of consistency we need to expand charsetaliases.properties...  

	Roy Yokoyama Assignee
	Comment 16 • 23 years ago

nhotta: can you review? thanks

	nhottanscp
	Comment 17 • 23 years ago

Comment on attachment 56800 [details] [diff] [review]
Adding ISO-8859-16 in charsetalias.properties

r=nhotta

	nhottanscp
	Comment 18 • 23 years ago

Comment on attachment 56799 [details] [diff] [review]
Making ISO-8859-16 to lower-case

r=nhotta

	Roy Yokoyama Assignee
	Comment 19 • 23 years ago

Filed a bugscape bug 10879 for commercial tree.

	Asa Dotzler [:asa]
	Comment 20 • 23 years ago

a=asa (on behalf of drivers) for checkin to 0.9.6

	Roy Yokoyama Assignee
	Comment 21 • 23 years ago

checked in to the trunk.
ylong: please wait until bugscape bug 10879 is checked-in for verification
       or download a mozilla build to verify.

	Yuying Long Reporter
	Comment 22 • 23 years ago

Fixed verified on 11-14 trunk build.

	Christopher Blizzard (:blizzard)
	Comment 23 • 23 years ago

OK, this is on the 0.9.6 branch, too.