Closed Bug 1087734 Opened 10 years ago Closed 10 years ago

Use close button ("x") on new tablet tab strip

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(2 files)

Attached image Screenshot, new icon (deleted) —
Anthony, what do you think?
Attachment #8509919 - Flags: feedback?(alam)
Comment on attachment 8509921 [details] [diff] [review] Use new close tab asset on new tablet tab strip Spare Lucas' review queue.
Attachment #8509921 - Flags: review?(lucasr.at.mozilla) → review?(mhaigh)
Comment on attachment 8509919 [details] Screenshot, new icon Looks good!
Attachment #8509919 - Flags: feedback?(alam) → feedback+
Comment on attachment 8509921 [details] [diff] [review] Use new close tab asset on new tablet tab strip Review of attachment 8509921 [details] [diff] [review]: ----------------------------------------------------------------- You don't need the mdpi or the xhdpi assets. As Commonsware mentions here http://stackoverflow.com/a/19196749/264276, the system will downscale from the largest given asset. You will, however, need to specify an hdpi asset, as neither xhdpi nor xxhdpi existed for API Level 7 and below. Up to you if you wanna play with that - we're tracking it on bug 959203. Patch looks good to go regardless.
Attachment #8509921 - Flags: review?(mhaigh) → review+
(In reply to Martyn Haigh (:mhaigh) from comment #5) > You don't need the mdpi or the xhdpi assets. As Commonsware mentions here > http://stackoverflow.com/a/19196749/264276, the system will downscale from > the largest given asset. You will, however, need to specify an hdpi asset, > as neither xhdpi nor xxhdpi existed for API Level 7 and below. Up to you if > you wanna play with that - we're tracking it on bug 959203. Patch looks > good to go regardless. I'm going to let bug 959203 take care of this - just in case we decide we don't want to move forward with this approach or backout, it makes things cleaner.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: