Closed Bug 1088 Opened 26 years ago Closed 26 years ago

Necko: Netlib performance ->URLImpl Locking Overhead

Categories

(Core :: Networking, defect, P2)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: troy, Assigned: rpotts)

References

Details

(Whiteboard: [Perf])

Currently URLImpl uses NSPR cached monitors in order to be thread safe. The problem is NSPR cached monitors have a very large performance overhead. Kipp pointed out that NSPR 2.0 has simple locks, see PR_NewLock() which on Windows are just a critical section. We should have one NSPR lock for all of the URLImpl objects which makes the resource overhead low
Summary: URLImpl Locking Overhead → ss:URLImpl Locking Overhead
rickg, would you consider this a ss: bug?
Summary: ss:URLImpl Locking Overhead → URLImpl Locking Overhead
Taking off ss: list per bug mtg today.
Assignee: rpotts → gagan
Re-assigned to gagan@netscape.com. Gagan, is this a netlib bug? Who should get this?
Status: NEW → ASSIGNED
I think that sounds feasible. Adding Warren for comments and accepting bug.
Summary: URLImpl Locking Overhead → Netlib performance ->URLImpl Locking Overhead
Summary: Netlib performance ->URLImpl Locking Overhead → [Perf]:Netlib performance ->URLImpl Locking Overhead
Noting [Perf] in summary. Starting to track bugs to review for performance milestone.
Setting all current Open/Normal to M4.
Summary: [Perf]:Netlib performance ->URLImpl Locking Overhead → Netlib performance ->URLImpl Locking Overhead
Whiteboard: [Perf]
Moving [Perf] from Status to Status Whiteboard.
setting paulmac as QA contact for all gagan's bugs (sorry for the spam)
Target Milestone: M4 → M6
Per DP's suggestion marking these till M8. Though Necko lands with M7, we will be able to verify it for M8.
I'm moving this to target M9, Necko will be enabled somewhere during late M8 or early M9. We will need to get on this and it cannot be postponed past the M9 milestone.
Blocks: 9164
Changing all Networking Library/Browser bugs to Networking-Core component for Browser. Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do this in a bulk change. If this happens, I will fix. ;-)
Summary: Netlib performance ->URLImpl Locking Overhead → Necko: Netlib performance ->URLImpl Locking Overhead
Probably not relevant with Necko. Pl. verify.
I don't believe that the URL methods need to be thread-safe now. The DOM and Netlib are no longer operating on the same object. Rick Potts should confirm this.
Assignee: gagan → rpotts
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
I'm resolving this bug because multiple threads are no longer sharing the same objects. It used to be that the underlying URL_Struct was manipulated by both the netlib thread and the UI thread. This is no longer the case... -- rick
Status: RESOLVED → VERIFIED
Bulk move of all Networking-Core (to be deleted component) bugs to new Networking component.
You need to log in before you can comment on or make changes to this bug.