Closed Bug 1088021 Opened 10 years ago Closed 7 years ago

Toolbar icons alignment issues

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: soeren.hentzschel, Unassigned)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image screenshot (deleted) —
Please see the screenhot. On OS X (10.10, HiDPI) the toolbar icons are not correctly vertical aligned, especially the Firefox Hello button.
Looks like you mean just the Firefox hello icon? Which other things in that screenshot do you think are misaligned?
Flags: needinfo?(cadeyrn)
Philipp, who knows about the Hello icon?
Flags: needinfo?(philipp)
(In reply to :Gijs Kruitbosch from comment #1) > Looks like you mean just the Firefox hello icon? Which other things in that > screenshot do you think are misaligned? It's probably more a size issue as an alignment issue, some icons are bigger than others, only the bookmark star and the new privacy button have the same height. But at least the hamburger icon looks misaligned, there is more space at bottom than at top. I'm not sure about the bookmark menu icon (not the star).
Flags: needinfo?(cadeyrn)
Clearing needinfo for Philipp, as Michael handled the icon for Hello. Michael, can you look in to this? Now that I look at it, I can't un-see it.
Flags: needinfo?(philipp) → needinfo?(mmaslaney)
OS: Mac OS X → All
Summary: [OS X] Toolbar icons alignment issues → Toolbar icons alignment issues
Sure thing. I'll go through the source files and nudge the glyph down a pixel or two.
Flags: needinfo?(mmaslaney)
(In reply to mmaslaney from comment #5) > Sure thing. I'll go through the source files and nudge the glyph down a > pixel or two. Besides moving, any way that we can normalize the size of these icons? This bug also mentions how some of the icons have colors that cover the full height of the icon, while others leave 1-3 pixels of transparency at the top and bottom of the icons.
Flags: needinfo?(mmaslaney)
Of course, I defer to you and the rest of the UX team to decide what the icons should look like. And if the current size of these icons is intentional then that is fine.
Attached file Hello_glyphs.zip (obsolete) (deleted) —
Updated space and dimension issues
Flags: needinfo?(mmaslaney)
Depends on: 1099952
Attached file Hello_Assets.zip (deleted) —
Optimized assets
Attachment #8513779 - Attachment is obsolete: true
Hello is no more and with Photon icon sizes and alignment of the toolbar icons looks great.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: