It would be useful to have telemetry on: 1) about:netError being seen for pin violations 2) users choosing to submit 3) users choosing to send automatically 4) errors encountered during send

This adds telemetry for the TLS error reporting code. NEEDINFOing bsmedberg as per https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Adding_a_new_Telemetry_probe since this adds a telemetry probe - Given https://bugzilla.mozilla.org/show_bug.cgi?id=846489#c74, I assume this will be fine.

Are you a good reviewer for this sort of thing or should I bug someone else?

Comment on attachment 8609315 [details] [diff] [review] telemetry_for_error_report.patch Review of attachment 8609315 [details] [diff] [review]: ----------------------------------------------------------------- The names around the UI_SHOWN and expanded could be improved a bit. The standard pageload triggers the TLS_ERROR_REPORT_TELEMETRY_UI_SHOWN metric, while there's an event called AboutNetErrorUIShown that triggers the TLS_ERROR_REPORT_TELEMETRY_UI_EXPANDED metric. Confusing.. I think the simplest would be to change your event name to AboutNetErrorUIExpanded. ::: browser/base/content/aboutNetError.xhtml @@ +112,5 @@ > .addEventListener('click', function togglePanelVisibility() { > var panel = document.getElementById('certificateErrorReportingPanel'); > toggleDisplay(panel); > + > + if (panel.style.display === 'block') { nit: our code style is to use " and ==, although I see some ' have already creeped in this file.

Feedback addressed, specifically: * replaced ' with " and === with == in the changes to aboutNetError.xhtml as per coding style. * Renamed the AboutNetErrorUIShown event to AboutNetErrorUIExpanded for greater clarity, as suggested.

(In reply to :Felipe Gomes from comment #3) > I see some ' have already > creeped in this file. Would you like me to do some cleanup in a followup bug for the other instances related to error reports?

No, I don't think it's necessary.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=414b186d5881 try is green