Closed Bug 1088180 Opened 10 years ago Closed 9 years ago

[e10s] after dragging tab to new window, links with target blank open in tabs in old window instead of current window

Categories

(Firefox :: Tabbed Browser, defect)

x86
Windows 7
defect
Not set
normal
Points:
8

Tracking

()

RESOLVED FIXED
Firefox 40
Iteration:
40.1 - 13 Apr
Tracking Status
e10s m6+ ---
firefox40 --- fixed

People

(Reporter: martin, Assigned: mconley)

References

Details

Attachments

(2 files)

Story
enable e10s
Open Multiple Tabs
drag some to a new window
All links with the target attribute set to _blank will open in the old window

Expected result:
Tabs opened by clicking links with target = _blank should open in the current window

Reproducible: Always on build ID Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141022030202 CSet: 88adcf8fef83

Possibly related bugs: bug 1047603
tracking-e10s: --- → ?
Depends on: 1012784
Sample Page with links that have target = _blank :
http://www.heise.de/security/meldung/lost-found-Was-von-der-Woche-uebrig-blieb-2411458.html (sorry german)
Blocks: e10s
Component: General → Tabbed Browser
Reproducible on build:
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141122030204 CSet: 7ab92d922d19
Flags: firefox-backlog+
dupe of bug 1124881?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 1134375
Assignee: nobody → mconley
Points: --- → 8
Flags: qe-verify-
Status: NEW → ASSIGNED
(In reply to Jim Mathies [:jimm] from comment #3)
> dupe of bug 1124881?

Possibly. Investigating now, and I'll see what I find out.
Unable to reproduce bug 1124881, so I've needinfo'd blassey.

I can still reproduce this one though, and the problem here is that we're not swapping the mBrowserDOMWindow's on the TabParent's when we swap remote frame loaders. Patch coming up.
Attached patch bug-1088180.patch (deleted) — Splinter Review
I assume because I have no direct access to the nsIBrowserDOMWindow pointers under TabParent that there's no other way of doing this?
Attachment #8590502 - Flags: review?(bugs)
Attachment #8590502 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/14f69f2f4712
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Iteration: --- → 40.1 - 13 Apr
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: