Joel Maher ( :jmaher ) (UTC -8) Reporter
	Description • 10 years ago

In the talos project: https://wiki.mozilla.org/Buildbot/Talos we have a variable defined for the logging module, but we are not really using it.  

this is in:
http://hg.mozilla.org/build/talos/file/tip/talos/scripts/MozillaFileLogger.js

we also have a reference to the variable here:
http://hg.mozilla.org/build/talos/file/tip/talos/page_load_test/quit.js

please clone the repository, grep for useSpecialPowers and remove all instances of it!

	Michael Romo Assignee
	Comment 1 • 10 years ago

BUG 1088252 - Remove variable 'useSpecialPowers' in Talos.

	Joel Maher ( :jmaher ) (UTC -8) Reporter
	Comment 2 • 10 years ago

Comment on attachment 8511999 [details] [diff] [review]
BUG 1088252 - Remove variable useSpecialPowers in Talos

Review of attachment 8511999 [details] [diff] [review]:
-----------------------------------------------------------------

a few things, mostly unindenting stuff that removed a if/try condition block.

::: talos/page_load_test/a11y/a11y.js
@@ +73,4 @@
>  // Walk accessible tree of the given identifier to ensure tree creation
>  function ensureAccessibleTree(aAccOrElmOrID)
>  {
> +  oacc = getAccessible(aAccOrElmOrID);

unindent this, and fix the typo of oacc to be acc :)

::: talos/scripts/MozillaFileLogger.js
@@ +3,3 @@
>   */
>  
>  // Detect if we are on older branches that don't have specialpowers enabled talos available

please remove this line as well

::: talos/startup_test/tspaint_test.html
@@ +22,5 @@
>        netscape.security.PrivilegeManager.enablePrivilege('UniversalXPConnect');
>        var startupInfo = Components.classes['@mozilla.org/toolkit/app-startup;1'].
>                                     getService(Ci.nsIAppStartup).getStartupInfo();
>        startupTime = now - startupInfo['process'];
>      } catch(ex) { dumpLog(ex + '\n'); }

please unindent this block of code

@@ +47,5 @@
>      try {
>        netscape.security.PrivilegeManager.enablePrivilege('UniversalXPConnect');
>        var consoleService = Components.classes['@mozilla.org/consoleservice;1'].getService(Components.interfaces.nsIConsoleService);
>        consoleService.getMessageArray(messages, {});
>      } catch(ex) { dumpLog(ex + '\n'); }

please unindent this block of code

	Joel Maher ( :jmaher ) (UTC -8) Reporter
	Comment 4 • 10 years ago

Comment on attachment 8512013 [details] [diff] [review]
BUG 1088252 - Remove useSpecialPowers variable from Talos

Review of attachment 8512013 [details] [diff] [review]:
-----------------------------------------------------------------

please merge the two patches and fix the trailing whitespace.

::: talos/startup_test/tspaint_test.html
@@ +24,3 @@
>                                     getService(Ci.nsIAppStartup).getStartupInfo();
> +    startupTime = now - startupInfo['process'];
> +  } catch(ex) { 

nit: please remove the whitespace at the end of this line and the one below it.

@@ +49,5 @@
> +  try {
> +    netscape.security.PrivilegeManager.enablePrivilege('UniversalXPConnect');
> +    var consoleService = Components.classes['@mozilla.org/consoleservice;1'].getService(Components.interfaces.nsIConsoleService);
> +    consoleService.getMessageArray(messages, {});
> +  } catch(ex) { 

nit: please remove the whitespace added at the end of this line and the next.

	Joel Maher ( :jmaher ) (UTC -8) Reporter
	Comment 7 • 10 years ago

Comment on attachment 8512035 [details] [diff] [review]
Remove whitespaces from previous patch.

Review of attachment 8512035 [details] [diff] [review]:
-----------------------------------------------------------------

awesome!

	Joel Maher ( :jmaher ) (UTC -8) Reporter
	Comment 8 • 10 years ago

https://hg.mozilla.org/build/talos/rev/eeac2f010641