Closed
Bug 1088353
Opened 10 years ago
Closed 10 years ago
[Homescreen] Moving applications around homescreen can shift a divider flush with the bottom of the screen
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.1 unaffected, b2g-v2.2 affected)
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | unaffected |
b2g-v2.2 | --- | affected |
People
(Reporter: onelson, Assigned: cwiiis)
References
()
Details
(Keywords: regression, Whiteboard: [2.2-Daily-Testing] [systemsfe])
Attachments
(3 files)
Description: When user attempts to create a new dividing group by moving the applications around the home screen, they can leave a divider empty without a line and reproduce the line flush with the bottom of the screen. This appears only a minor visual bug with no functional impact. The divider can be reset by resituating the moved icons and removing the new "group". Identical issue to: https://bugzilla.mozilla.org/show_bug.cgi?id=1028841 Repro Steps: 1) Update a Flame device to BuildID: 20141023040204 2) Hold tap on an application to enter Edit Mode. 3) Drag application between 2 groups of applications and drop to create new grouping. 4) Place application in new grouping. 5) Tap 'Done' in top right corner. 6) Observe UI. Actual: New grouping divider is missing a line; new line is flush with the bottom of the screen. Expected: New grouping displays accurately. ********************************************* Environmental Variables: ---------------------------------------------- Issue REPROES on Flame 2.2 Results: New grouping divider is missing a line; new line is flush with the bottom of the screen. Device: Flame 2.2 Master BuildID: 20141023040204 Gaia: 27a1d1baaa8e375b70e043efee67d5f2206c330b Gecko: 88adcf8fef83 Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d Version: 36.0a1 (2.2 Master) Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0 ================================================================== Issue DOES NOT REPRO on Flame 2.1 Results: New grouping displays accurately. Note** Build does not have the functionality to create new groupings Device: Flame 2.1 BuildID: 20141023001201 Gaia: 1e48e3e40e0780c0cd07a3457e5fe2efeeb542d1 Gecko: 09fb60a37850 Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d Version: 34.0 (2.1) Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 ---------------------------------------------- Repro frequency: 3/3 See attached: screenshot video logcat
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Whiteboard: [2.1-FC-bug-bash] → [2.2-Daily-Testing] [systemsfe]
Comment 2•10 years ago
|
||
Need info on the qa lead for homescreen for blocking nomination decision.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga) → needinfo?(mozillamarcia.knous)
Keywords: regression
Comment 3•10 years ago
|
||
Nominating for blocking. This seems to have regressed, and it seems we also treated the original bug as a blocker so seems logical.
blocking-b2g: --- → 2.2?
Flags: needinfo?(mozillamarcia.knous)
Updated•10 years ago
|
Keywords: regressionwindow-wanted
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+]
QA Contact: pcheng
Comment 4•10 years ago
|
||
Please be noted that the 'working' build here does NOT possess the feature of adding a divider in between two groupings. ---- b2g-inbound regression window: Last Working (Feature non-existent): Device: Flame BuildID: 20140924111252 Gaia: 03d7bcad57ea281869976a9aed0a38849f7c8bc5 Gecko: 9c071f5ae50a Version: 35.0a1 (2.2 Master) Firmware: V188-1 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 First Broken Environmental Variables: Device: Flame BuildID: 20140924115754 Gaia: 997fe515e4417301d9e0c0704c7e3beb19179db5 Gecko: f43a1fed8fcb Version: 35.0a1 (2.2 Master) Firmware: V188-1 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 First Broken Gaia & Last Working Gecko - issue DOES repro Gaia: 997fe515e4417301d9e0c0704c7e3beb19179db5 Gecko: 9c071f5ae50a First Broken Gecko & Last Working Gaia - feature does NOT exist Gaia: 03d7bcad57ea281869976a9aed0a38849f7c8bc5 Gecko: f43a1fed8fcb Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/03d7bcad57ea281869976a9aed0a38849f7c8bc5...997fe515e4417301d9e0c0704c7e3beb19179db5 Caused by Bug 1067435.
Comment 5•10 years ago
|
||
Caused by Bug 1067435 - can you take a look Chris?
Blocks: app-grouping
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmitchell) → needinfo?(chrislord.net)
QA Contact: pcheng
Assignee | ||
Comment 6•10 years ago
|
||
We're going to enable app-grouping by default soon, and I don't think it's intended to be an option you can turn off, by which point this bug will become obsolete. The styling that makes sure the last divider isn't visible worked because we'd always recreate the last divider, but we can't do this with grouping as the divider represents the group above it. We could add a style class for the last divider I suppose, and style on that... Shouldn't take long, so I'll fix this anyway.
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
Flags: needinfo?(chrislord.net)
Assignee | ||
Comment 7•10 years ago
|
||
I would ask for a special permission to not write a test for this - once we turn on app grouping, this will become redundant and we can just remove this, and the style rule in verticalhome.
Attachment #8518876 -
Flags: review?(kgrandon)
Comment 8•10 years ago
|
||
Is it worth while even doing this if we are about to enable app grouping? I can follow-up with you on IRC next week, but have we determined the date of when we're going to enable it?
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Kevin Grandon :kgrandon from comment #8) > Is it worth while even doing this if we are about to enable app grouping? I > can follow-up with you on IRC next week, but have we determined the date of > when we're going to enable it? If we get bug 1091007 in today, I think we should enable it on Monday. So perhaps we should just WONTFIX this...
Comment 10•10 years ago
|
||
Comment on attachment 8518876 [details] Make sure last divider is not visible The code looks fine, but my preference would be to just turn this on by default as we need to remove this code anyway I believe? Now that bug 1091007 is in, I think we should just go forward and enable shelves.
Attachment #8518876 -
Flags: review?(kgrandon)
Comment 11•10 years ago
|
||
Marking as WONTFIX as the plan is to turn on shelves support so we won't need this. Thank you for filing and the patch. Feel free to re-open in case we *do* need to fix this still for some reason.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Updated•10 years ago
|
blocking-b2g: 2.2? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•