Closed
Bug 1088362
Opened 10 years ago
Closed 10 years ago
Ask the API for a greater Cache-control: max-age value for homepage endpoint
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-11-04
People
(Reporter: mat, Assigned: mat)
References
Details
Since the homepage content doesn't change very often, fireplace should pass a greater cache={value} when requesting the homepage API endpoint so that it can be cached for a longer time by the browser. In bug 1085739 we settled for 6 hours, let's try that.
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Fixed in https://github.com/mozilla/fireplace/commit/6d0278456bb81ba768d8c34d24cbe5ef141c818b QA: - Clear your browser cache - Load marketplace with developer tools network tab opened - Look in XHR for a request made to /api/v2/feed/get/?cache=21600&lang=<lang>&limit=10®ion=<lang>&vary=0 - Check that this request has a header Cache-Control: must-revalidate, max-age=21600 (and not just max-age=180) - Reload the page - Check that it displays correctly and the request is no longer present (because it has been cached by the browser and the CDN for 6 hours)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2014-11-04
Comment 2•10 years ago
|
||
Verified as fixed in https://marketplace-dev.allizom.org/ on FF36 (Win 7). Postfix screencast http://screencast.com/t/M713OPbF Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•