Closed
Bug 1088364
Opened 10 years ago
Closed 10 years ago
Remove use cases of mozL10n.localize from Bluetooth
Categories
(Firefox OS Graveyard :: Gaia::Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Hard to grep case of mozL10n.localize use. I believe it's the last one.
Attachment #8510678 -
Flags: review?(stas)
Assignee | ||
Updated•10 years ago
|
Attachment #8510678 -
Flags: review?(stas) → review?(echou)
Comment 2•10 years ago
|
||
Comment on attachment 8510678 [details]
pull request
Delegate review request to Ian since he is the owner of Gaia bluetooth app and this is a Gaia change.
Attachment #8510678 -
Flags: review?(echou) → review?(iliu)
Comment 3•10 years ago
|
||
Comment on attachment 8510678 [details]
pull request
Hi Zibi, I leave some comment on GitHub. Basically, we have to sync the code base with https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/bluetooth.js . It's a duplicated one for implementation embedded Bluetooth app in the future. Thanks.
Attachment #8510678 -
Flags: review?(iliu)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8510678 [details]
pull request
Updated PR
Attachment #8510678 -
Flags: review?(iliu)
Comment 5•10 years ago
|
||
Comment on attachment 8510678 [details]
pull request
Thanks for Zibi's help here. Working and r+ with me.
Attachment #8510678 -
Flags: review?(iliu) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Thanks Ian!
Commit: https://github.com/zbraniecki/gaia/commit/d95939ba0225577f4cc08eec98f2894ad939c9eb
Merge: https://github.com/mozilla-b2g/gaia/commit/a4081b6306b36c63ee184da97f48c4634647b8a1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•