Closed
Bug 1088413
Opened 10 years ago
Closed 10 years ago
Icons at bottom of Gallery single portrait view are not correct.
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(ux-b2g:2.2, b2g-v2.2 verified, b2g-master verified)
VERIFIED
FIXED
ux-b2g | 2.2 |
People
(Reporter: swilkes, Assigned: pdahiya)
References
Details
(Whiteboard: [2.1-bug-bash] )
Attachments
(3 files)
See attached screenshot. Bottom bar appears to have white and gray icons crowded at the bottom.
* Set language to Arabic.
* Select photo from Gallery.
* Observe blank screen instead of expected photo (this issue is bug #1088407).
* Observe two colors of crowded icons at bottom of screen.
Reporter | ||
Comment 1•10 years ago
|
||
Disregard - only showing on phone and intermittently; can't seem to nab it in the screenshot.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Whiteboard: [2.1-FC-bug-bash] → [2.1-bug-bash]
Comment 2•10 years ago
|
||
Reopening this bug and assigning to Punam. Disregard comment #0, but see the screenshot: the buttons are laid out rtl in that screenshot, but they are not supposed to be since none of them are directional. (You can double-check me on that, but I'm pretty sure that the spec says that buttons in a toolbar don't change their position if they are not directional).
I think that this just needs a hardcoded dir="ltr" in the HTML for the toolbar or direction:ltr in the CSS for the toolbar. (The CSS fix is probably better)
Assignee: nobody → pdahiya
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Assignee | ||
Comment 3•10 years ago
|
||
Hi David
I have attached PR with the css fix to keep icons in fullscreen toolbar and image edit toolbar to stay LTR. Please review. Thanks!
Attachment #8530955 -
Flags: review?(dflanagan)
Comment 4•10 years ago
|
||
Comment on attachment 8530955 [details]
PR with fix of Bug1088413
r- because I think this patch could be even simpler. No need (I think) for the html[dir="rtl"]. I think you can just hardcode these two toolbar elements with direction:ltr unconditionally.
Attachment #8530955 -
Flags: review?(dflanagan) → review-
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8530955 [details]
PR with fix of Bug1088413
Patch updated with review feedback, please review. Thanks!
Attachment #8530955 -
Flags: review- → review?(dflanagan)
Comment 6•10 years ago
|
||
Comment on attachment 8530955 [details]
PR with fix of Bug1088413
Looks good. Thanks.
Attachment #8530955 -
Flags: review?(dflanagan) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Thanks David, patch landed on master
https://github.com/mozilla-b2g/gaia/commit/a59198af43708807bd826075680c20257cc32fba
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 8•10 years ago
|
||
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15913/
Flags: in-moztrap+
This issue has been verified as pass on latest build of Flame 2.2/3.0 and Nexus 5 2.2/3.0 by STRs in comment 0.
See attachment:verify_pass.png
Rate:0/5
Device: Flame 2.2 (pass)
Build ID 20150511002500
Gaia Revision 528ef60e7cda09ad43478065f5d33bda398fbeb7
Gaia Date 2015-05-08 23:40:58
Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d04cc085cf5
Gecko Version 37.0
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150511.035847
Firmware Date Mon May 11 03:58:59 EDT 2015
Bootloader L1TC000118D0
Device: Flame 3.0 (pass)
Build ID 20150511160205
Gaia Revision 6089234ace8b294a8feef064387604bae16254e3
Gaia Date 2015-05-10 13:57:12
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/502e1a5e722f
Gecko Version 41.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150511.193556
Firmware Date Mon May 11 19:36:04 EDT 2015
Bootloader L1TC000118D0
Device: Nexus 5 2.2 (pass)
Build ID 20150511002500
Gaia Revision 528ef60e7cda09ad43478065f5d33bda398fbeb7
Gaia Date 2015-05-08 23:40:58
Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d04cc085cf5
Gecko Version 37.0
Device Name hammerhead
Firmware(Release) 5.1
Firmware(Incremental) eng.cltbld.20150511.034716
Firmware Date Mon May 11 03:47:32 EDT 2015
Bootloader HHZ12f
Device: Nexus 5 3.0 (pass)
Build ID 20150511160205
Gaia Revision 6089234ace8b294a8feef064387604bae16254e3
Gaia Date 2015-05-10 13:57:12
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/502e1a5e722f
Gecko Version 41.0a1
Device Name hammerhead
Firmware(Release) 5.1
Firmware(Incremental) eng.cltbld.20150511.193757
Firmware Date Mon May 11 19:38:13 EDT 2015
Bootloader HHZ12f
Comment 10•10 years ago
|
||
The Arabic is not ready for v2.1 yet. So close this issue.
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
status-b2g-v2.2:
--- → verified
status-b2g-master:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•