Closed
Bug 1088497
Opened 10 years ago
Closed 10 years ago
Implement NewChannel2 in mailnews
Categories
(MailNews Core :: Networking, defect)
MailNews Core
Networking
Tracking
(thunderbird36 fixed)
RESOLVED
FIXED
Thunderbird 36.0
| Tracking | Status | |
|---|---|---|
| thunderbird36 | --- | fixed |
People
(Reporter: rkent, Assigned: rkent)
References
Details
(Keywords: dogfood, regression)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
Bug 1067471 breaks mailnews by adding a new method to nsIProtocolHandler, newChannel2. There are lots of other implications of this as well that we need to investigate, see bug 1038756.
|
Assignee | |
Comment 1•10 years ago
|
||
I don't think this is the end of the issues that will result from the ongoing Netwerk changes, but at least this builds and passes a smoke test.
|
||
Updated•10 years ago
|
Blocks: 1067471
Keywords: regression
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8510853 [details] [diff] [review]
Add NewChannel2 to mailnews
Review of attachment 8510853 [details] [diff] [review]:
-----------------------------------------------------------------
::: mailnews/addrbook/src/nsAddbookProtocolHandler.cpp
@@ +118,5 @@
> {
> + return NewChannel2(aURI, nullptr, _retval);
> +}
> +
> +NS_IMETHODIMP
EWHITESPACE
|
|
Assignee | |
Comment 3•10 years ago
|
||
I'll be mostly AFK for the next few days, so please move this ahead without me if there are further issues.
Attachment #8510853 -
Attachment is obsolete: true
Attachment #8510853 -
Flags: review?(Pidgeot18)
Attachment #8511142 -
Flags: review?(Pidgeot18)
|
|
||
Updated•10 years ago
|
Attachment #8511142 -
Flags: review?(Pidgeot18) → review+
|
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
|
||
Comment 5•10 years ago
|
||
Thanks for fixing this in chat/ too! While I'm happy it's fixed and don't think a review from a chat peer was needed here, I would appreciate if in similar situations in the future you could ensure at least one chat peer is in the cc list of the bug. Thanks!
|
|
Assignee | |
Comment 6•10 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #5)
> Thanks for fixing this in chat/ too! While I'm happy it's fixed and don't
> think a review from a chat peer was needed here, I would appreciate if in
> similar situations in the future you could ensure at least one chat peer is
> in the cc list of the bug. Thanks!
OK that's a good approach to this kind of issue.
BTW the chat changes were added per an IRC request from jcranmer.
|
||
Updated•10 years ago
|
status-thunderbird36:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•