Closed
Bug 1089025
Opened 10 years ago
Closed 10 years ago
C-C TB: Chrome file doesn't exist: chrome/toolkit/content/global/charsetOverlay.js
Categories
(Thunderbird :: Message Compose Window, defect)
Thunderbird
Message Compose Window
Tracking
(thunderbird36 fixed)
RESOLVED
FIXED
Thunderbird 36.0
Tracking | Status | |
---|---|---|
thunderbird36 | --- | fixed |
People
(Reporter: ishikawa, Assigned: mkmelin)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bwinton
:
review+
|
Details | Diff | Splinter Review |
During the run of |make mozmill| test suite of C-C TB (I used
local DEBUG BUILD version of TB),
I saw the following error.
(This was noticed in analyzing the Bug 1086605
TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/addrbook/test-address-book.js | test_writing_to_mailing_list
Step Pass: {"function": "controller.click()"}
Chrome file doesn't exist: /REF-OBJ-DIR/objdir-tb3/dist/bin/chrome/toolkit/content/global/charsetOverlay.js
[24286] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /REF-COMM-CENTRAL/comm-central/mozilla/netwerk/base/src/nsFileStreams.cpp, line 205
[24286] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /REF-COMM-CENTRAL/comm-central/mozilla/netwerk/base/src/nsFileStreams.cpp, line 492
Failed to load file:///REF-OBJ-DIR/objdir-tb3/dist/bin/chrome/toolkit/content/global/charsetOverlay.js
JavaScript strict warning: , line 0: TypeError: setting a property that has only a getter
From https://bugzilla.mozilla.org/show_bug.cgi?id=1086605#c2
--- begin quote ---
Using
I searched for the file charsetOverlay.js but it is not in C-C.
I searched for the string charsetOverlay.js and it is in
mail/components/compose/content/messengercompose.xul (View Hg log or Hg annotations)
line 69 -- <script type="application/javascript" src="chrome://global/content/charsetOverlay.js"/>
Maybe another file that disappeared in the last three months or so?
I checked old log files and this error was not seen on June 25 local log.
My PC had a hardware hiccup and I could not much on TB during the summer,
and late September when I updated my source and re-ran the test,
the above error line appeared and still persists until today.
--- end quote ---
Reporter | ||
Updated•10 years ago
|
Summary: C-C TB: Chrome file doesn't exist: MOZ_OBJECT/dist/bin/chrome/toolkit/content/g → C-C TB: Chrome file doesn't exist: chrome/toolkit/content/global/charsetOverlay.js
Assignee | ||
Comment 1•10 years ago
|
||
hg log -r 'removes(toolkit/content/charsetOverlay.js)'
--> removed in bug 943252
Assignee | ||
Comment 2•10 years ago
|
||
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8511500 -
Flags: review?(bwinton)
Comment 3•10 years ago
|
||
Fallout from Bug 999881 - Use CharsetMenu instead of the old charsetOverlay in Thunderbird
https://hg.mozilla.org/comm-central/rev/416056a645fe
https://hg.mozilla.org/comm-central/rev/7f010544c325
Blocks: 999881
Comment 4•10 years ago
|
||
Comment on attachment 8511500 [details] [diff] [review]
bug1089025_charsetOverlay_is_gone.patch
Looks good to me by inspection.
Attachment #8511500 -
Flags: review?(bwinton) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Updated•10 years ago
|
status-thunderbird36:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•