Closed
Bug 1089030
Opened 10 years ago
Closed 10 years ago
Invalid mochitest skipped in dom/contacts/tests/mochitest.ini
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jgilbert, Assigned: vaibhav1994)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
> 16:07:15 INFO - Warning: shared.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/contacts/tests/mochitest.ini is not a valid test
|
Assignee | |
Comment 1•10 years ago
|
||
Are the changes done in the attached patch expected or am I missing something?
(since the file is in mochitest.ini and not .html, I think it should be a support file).
Flags: needinfo?(jmaher)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8514025 [details] [diff] [review]
manifest.patch
Review of attachment 8514025 [details] [diff] [review]:
-----------------------------------------------------------------
this looks to be the right thing.
Attachment #8514025 -
Flags: review+
|
|
||
Updated•10 years ago
|
Flags: needinfo?(jmaher)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Great. The try push for this patch: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1c0d59cc20bb
|
|
Assignee | |
Comment 4•10 years ago
|
||
The try push is green and shared.js is no longer in the warning logs
Assignee: nobody → vaibhavmagarwal
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
|
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
|
|
Assignee | |
Comment 7•10 years ago
|
||
Thanks Ryan! :)
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•