Kelsey Gilbert [:jgilbert] Reporter
	Description • 10 years ago

> 16:07:15     INFO -  Warning: test_BOMEncoding.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_TextDecoder.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_TextEncoder.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/mochitest.ini is not a valid test

	Vaibhav (:vaibhav1994) Assignee
	Comment 1 • 10 years ago

Try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5eb57dcac4ad

	Vaibhav (:vaibhav1994) Assignee
	Comment 2 • 10 years ago

Comment on attachment 8514349 [details] [diff] [review]
manifest.patch

Try push is green and warnings not present for the above tests. :jmaher, adding you as the reviewer.

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 3 • 10 years ago

Comment on attachment 8514349 [details] [diff] [review]
manifest.patch

Review of attachment 8514349 [details] [diff] [review]:
-----------------------------------------------------------------

awesome, thanks!

	Carsten Book [:Tomcat]
	Comment 4 • 10 years ago

needs rebasing i guess

Hunk #1 FAILED at 3
1 out of 1 hunks FAILED -- saving rejects to file dom/encoding/test/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh manifest4.patch

	Vaibhav (:vaibhav1994) Assignee
	Comment 5 • 10 years ago

Fixed for bitrot.

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/8eafdf1f34ec

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/8eafdf1f34ec