Closed
Bug 1089301
Opened 10 years ago
Closed 10 years ago
Investigating cheating on matching address headers to improve search/filter speed
Categories
(MailNews Core :: Search, defect)
Tracking
(thunderbird38+ fixed)
VERIFIED
FIXED
Thunderbird 38.0
People
(Reporter: jcranmer, Assigned: jcranmer)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
(deleted),
patch
|
rkent
:
review+
|
Details | Diff | Splinter Review |
Parsing addressing headers is relatively expensive. The logic we use in the search code is basically "matches any name or any email"--if we're using the Contains/DoesntContain match properties, we don't even need to parse the address headers and we could use a mere decoded header instead (potentially faster if bug 1089229 is fixed and extended to addressing headers). Even the other matches could be filtered with a prepass if we expect them to fire relatively infrequently.
Assignee | ||
Comment 1•10 years ago
|
||
This requires the patches over in bug 1089298 to apply. Since quick search only does a Contains match, this makes it REALLY fast.
Assignee | ||
Updated•10 years ago
|
tracking-thunderbird38:
--- → ?
Comment 2•10 years ago
|
||
Comment on attachment 8559279 [details] [diff] [review]
Oh hey, this is fast
Review of attachment 8559279 [details] [diff] [review]:
-----------------------------------------------------------------
This need for patch is a good example of the types of issues we are going to continue to face if we try to convert most things to javascript. You have this beautiful javascript code that does precise mime processing - but then you have to hack around it because it is slower than we want, and we end up introducing approximations like this to get the speed up.
Still, I think that we need to do this. But we will need to be on the lookout for unforeseen issues with this search approximation.
Attachment #8559279 -
Flags: review?(rkent) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
Updated•10 years ago
|
status-thunderbird38:
--- → fixed
Comment 4•10 years ago
|
||
thanks. speed is much better
Status: RESOLVED → VERIFIED
Summary: Investigating cheating on matching address headers → Investigating cheating on matching address headers to improve search/filter speed
Assignee | ||
Updated•10 years ago
|
Flags: in-testsuite-
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•