Similar to the bookmarks patch in bug 1081099, we need a way to notify history observers from the new History.jsm module and from nsPlacesExpiration (see bug 937560 comment 15). Once that's in place, nsPIPlacesHistoryListenersNotifier should be removed. This may be done in a follow up.

yep, sounds like a nice cleanup to do.

OK, we've got a "similar to this other patch". If we can get a DXR link in here, this looks like a good mentored but. Mano, feel like mentoring a contributor through this?

Of course but we need this fixed in the next few weeks. If it cannot happen by then (and the sooner the better). I'll take it myself, or maybe Marco will. http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsINavBookmarksService.idl#550 <- Port that to nsINavHistoryService.idl http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsNavBookmarks.cpp#2674 <- Port that to nsNavHistory.cpp And there's also the test: http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/test_bookmark_catobs.js

taking cause it's needed for bug 1090308.

Marco please add this to the current iteration

Added to IT 36.3

/r/783 - Bug 1089332 - Add a getObservers API for accessing the history observers list. r=Mano Pull down this commit: hg pull review -r 5f5fef9378a8dc3ac9efaf297c6208ead39db21d

/r/783 - Bug 1089332 - Add a getObservers API for accessing the history observers list. r=Mano /r/785 - Bug 1090308 - Invalidate mDaysOfHistory when getObservers is invoked. r=Mano Pull down these commits: hg pull review -r 598e4a507f2731d62b60bc13ba00ecc86d4a7608

https://reviewboard.mozilla.org/r/783/#review443 ::: toolkit/components/places/tests/unit/test_history_catobs.js (Diff revision 1) > + let notificationsPromised = new Promise((resolve, reject) => { trailing spaces

https://reviewboard.mozilla.org/r/783/#review445 Ship It!

https://reviewboard.mozilla.org/r/783/#review447 Ship It!