Christoph Kerschbaumer [:ckerschb] Assignee
	Description • 10 years ago

Since Bug 946065 already moved code from content/ into dom/ I think it's time to actually create dom/security and move CSP and also MixedContentBlocker into it. Ideally we would end up having:

> dom/security/csp
> dom/security/mixedcontentblocker

and hopefully soon

> dom/security/sri


Additional note: I already filed Bug 1086619, so that we have not only CSP mochitests in one directory, but also mixed content tests.

	Tanvi Vyas[:tanvi]
	Comment 1 • 10 years ago

+1

	Christoph Kerschbaumer [:ckerschb] Assignee
	Comment 2 • 10 years ago

I think it's the better solution to move all the csp-files into
> dom/security

No need for additonal subfolders within security/.

Once we land this patch we should also update:
> https://wiki.mozilla.org/Modules/All#Content_Security

	Sid Stamm [:geekboy or :sstamm]
	Comment 4 • 10 years ago

Comment on attachment 8512866 [details] [diff] [review]
bug_1089912_1_move_csp_into_dom_security.patch

Review of attachment 8512866 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks good, but defer to jst.

	Christoph Kerschbaumer [:ckerschb] Assignee
	Comment 5 • 10 years ago

When pushing to try [1] I realized that I forgot to add dom_security to all the different package-manifest files. incorporated that change now. Carrying over r+ from jst and sstamm.


[1] https://tbpl.mozilla.org/?tree=Try&rev=56915b0016cf

	Christoph Kerschbaumer [:ckerschb] Assignee
	Comment 6 • 10 years ago

Had to rebase this one as well after pulling mc.
Carrying over r+ from jst and tanvi.

	Christoph Kerschbaumer [:ckerschb] Assignee
	Comment 7 • 10 years ago

Here we go, try is green:
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2008ae73a2f4

Problem fixed by adding dom_security to the different pagacke-manigest files (see Comment 5).

I will land soon, right after landing some csp changes, otherwise I would have to rebase those patches.

	Christoph Kerschbaumer [:ckerschb] Assignee
	Comment 8 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9de623894ce3
https://hg.mozilla.org/integration/mozilla-inbound/rev/4111cfcf8636

	Carsten Book [:Tomcat]
	Comment 9 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/9de623894ce3
https://hg.mozilla.org/mozilla-central/rev/4111cfcf8636