Closed
Bug 1090018
Opened 10 years ago
Closed 10 years ago
Unexpected space shows on the bottom of keyboard when passcode and software home button are enabled
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gduan, Assigned: gweng)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
STR:
1. enable simpin and software home button and passcode.
2. restart device and unlock screen
Actual: transparent space shows on the bottom of number keyboard
Expect: keyboard should be aligned at the bottom
|
Assignee | |
Comment 2•10 years ago
|
||
Although I feel to concat the ':not' to let become longer and longer may be not a good idea, but since it's the existing logic so I follow it to patch this bug.
Flags: needinfo?(gweng)
Attachment #8512434 -
Flags: review?(alive)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → gweng
Whiteboard: [p=1]
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8512434 [details]
Patch
Please mark the dependency (regression of lockscreenInputWindow)
Attachment #8512434 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
The patch only encountered one ringtone intermittent test failure:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=632cfcc3c82e
Which had failed at other patches like this:
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=7142abc41b09
So I would land this patch.
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•