Closed
Bug 109029
Opened 23 years ago
Closed 23 years ago
show_bug should generate valid html
Categories
(Bugzilla :: Bugzilla-General, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: pali, Assigned: gerv)
References
()
Details
(Whiteboard: [blocker will fix])
Attachments
(1 file)
(deleted),
patch
|
afranke
:
review+
bbaetz
:
review+
|
Details | Diff | Splinter Review |
show_bug.cgi should generate valid html. see the url.
Updated•23 years ago
|
Target Milestone: --- → Bugzilla 2.16
Comment 1•23 years ago
|
||
We are currently trying to wrap up Bugzilla 2.16. We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut. Thus this is being retargetted at 2.18. If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18
Comment 2•23 years ago
|
||
Should be a 2.16 blocker.
Severity: normal → blocker
Priority: -- → P1
Target Milestone: Bugzilla 2.18 → Bugzilla 2.16
Assignee | ||
Comment 3•23 years ago
|
||
I'm templatising show_bug over in 110012 - I'll fix this on the way.
Gerv
Updated•23 years ago
|
Summary: show_bug shold generate valid html → show_bug should generate valid html
Whiteboard: [blocker will fix]
Assignee | ||
Comment 5•23 years ago
|
||
This bug is just about fixed. The remaining issues are:
- wrap="hard"
- <nobr> in the attachment template
- a mess-up with quotes in the onchange JS
- a missing </b> tag
A patch is about to be attached for these last two issues. I'm not going to mess
with the attachment template, because it might break something. CCing Myk.
Gerv
Assignee | ||
Comment 6•23 years ago
|
||
Assignee | ||
Comment 7•23 years ago
|
||
This is tiny - someone should be able to review this in 30 seconds. It's a
two-liner; it only looks more because I changed the indentation.
Gerv
Comment 8•23 years ago
|
||
Comment on attachment 75775 [details] [diff] [review]
Patch v.1
r=afranke. I have installed the patch and 'onchange' in the reassign field
works as expected.
I would prefer the "(this.value..." expressions to line up, but I'm unsure
about the style conventions.
Attachment #75775 -
Flags: review+
Comment 9•23 years ago
|
||
Comment on attachment 75775 [details] [diff] [review]
Patch v.1
r=bbaetz. The 2nd hunk of this was already checked in - see bug 133201.
Attachment #75775 -
Flags: review+
Assignee | ||
Comment 10•23 years ago
|
||
Fixed.
Checking in template/default/show/show_bug.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/default/show/show_bug.html.tmpl,v
<-- show_bug.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Gerv
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•