Open Bug 1090578 Opened 10 years ago Updated 2 years ago

Improve error handling when creating new protocols via Open/Bridge

Categories

(Core :: IPC, defect)

x86_64
Linux
defect

Tracking

()

People

(Reporter: billm, Unassigned)

Details

Right now we have a lot of code that looks like this: ProcessHandle handle; if (!base::OpenProcessHandle(aOtherProcess, &handle)) { // XXX need to kill |aOtherProcess|, it's boned return nullptr; } DebugOnly<bool> ok = parent->Open(aTransport, handle, XRE_GetIOMessageLoop(), mozilla::ipc::ParentSide); MOZ_ASSERT(ok); (The same "it's boned" comment already appears in three places in Gecko and bug 641685 will add a fourth.) We should really do a better job here. I'm not sure what scenarios these calls could fail in. We should either crash or handle the error gracefully.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.