Closed
Bug 1090756
Opened 10 years ago
Closed 9 years ago
TEST-UNEXPECTED-FAIL | null | Vertical - Collection Rename rename collection
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: rudyl, Unassigned)
References
Details
(Keywords: intermittent-failure, Whiteboard: [systemsfe])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
example failed try run,
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=98c553b4f9b7
====
20:05:36 INFO - 1) Vertical - Collection Rename rename collection:
20:05:36 INFO - JavaScriptError: (17) unload was called
20:05:36 INFO - Remote Stack:
20:05:36 INFO - <none>
20:05:36 INFO - at Error.MarionetteError (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)
20:05:36 INFO - at Object.Client._handleCallback (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:476:19)
20:05:36 INFO - at /builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:510:21
20:05:36 INFO - at TcpSync.send (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:153:10)
20:05:36 INFO - at Object.send (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)
20:05:36 INFO - at Object.Client._sendCommand (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:503:19)
20:05:36 INFO - at Object._executeScript (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:1468:19)
20:05:36 INFO - at Object.executeAsyncScript (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:1249:19)
20:05:36 INFO - at Object.Client.waitForSync (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:676:14)
20:05:36 INFO - at Object.Client.waitFor (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:650:60)
20:05:36 INFO - at Object.MarionetteHelper.waitForElement (/builds/slave/test/gaia/node_modules/marionette-helper/index.js:142:12)
20:05:36 INFO - at Object.Collection.renameAndPressEnter (/builds/slave/test/gaia/apps/verticalhome/test/marionette/lib/collection.js:261:24)
20:05:36 INFO - at Context.<anonymous> (/builds/slave/test/gaia/apps/verticalhome/test/marionette/collection_rename_test.js:50:16)
20:05:36 INFO - at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:223:21)
20:05:36 INFO - at Test.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
20:05:36 INFO - at Runner.runTest (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:373:10)
20:05:36 INFO - at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:451:12
20:05:36 INFO - at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:298:14)
20:05:36 INFO - at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:308:7
20:05:36 INFO - at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:246:23)
20:05:36 INFO - at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
20:05:36 INFO - at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
20:05:36 INFO - at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:228:7)
20:05:36 INFO - at Hook.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
20:05:36 INFO - at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:258:10)
20:05:36 INFO - at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
20:05:36 INFO - at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
20:05:36 INFO - at /builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:199:9
20:05:36 INFO - at Object.executeHook (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18)
20:05:36 INFO - at process._tickCallback (node.js:415:13)
20:05:36 INFO - make: *** [test-integration-test] Error 1
20:05:36 ERROR - Return code: 2
20:05:36 INFO - TinderboxPrint: gaia-integration-tests: 71/<em class="testfail">1</em>/2
20:05:36 ERROR - Tests exited with return code 2: harness failures
20:05:36 ERROR - # TBPL FAILURE #
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Rudy, thanks for filing the bug.
Comment 3•10 years ago
|
||
Disable the failing test: https://github.com/mozilla-b2g/gaia/commit/bc0a882efd1df127c9312b227dfb08f97220ea48
Comment 4•10 years ago
|
||
Since this is not a new test, please try to track down the platform issue before disabling the test in the future. Also you should use TBPL-manifest instead of doing it in the test if possible.
This is likely a gecko regression that broke us, and masking these issues does not do us good.
Updated•10 years ago
|
Whiteboard: [systemsfe]
Comment 5•10 years ago
|
||
This is the likely pushlog that broke the test: https://tbpl.mozilla.org/?tree=B2g-Inbound&showall=1&jobname=b2g_ubuntu64_vm%20b2g-inbound%20opt%20test%20gaia-js-integration-4&rev=33fe81089497
Comment 6•10 years ago
|
||
Tracking it to this merge: https://tbpl.mozilla.org/?rev=9fd712fd9a6c from inbound -> m-c.
Comment 7•10 years ago
|
||
Re-landed with this disabled from the manifest: https://github.com/mozilla-b2g/gaia/commit/1f1e9dff4c802c9e940f8976709f2378ec518db7
Comment 8•10 years ago
|
||
I have a hunch that this is likely caused by bug 1013625 landing. Going to run some tests now to verify.
Blocks: 1013625
Comment 9•10 years ago
|
||
Paolo, Bz - Can you guys see bug 1013625 causing any problems with promises if we close a frame while one is "queued"? I don't see much in the log, but the following does appear:
JavaScriptError: (17) unload was called
Flags: needinfo?(paolo.mozmail)
Flags: needinfo?(bzbarsky)
Comment 10•10 years ago
|
||
> Can you guys see bug 1013625 causing any problems with promises if we close a frame while
> one is "queued"?
Possibly. Depending on how exactly the frame is "closed" and whether the callbacks to run come from the now-closed frame.
Flags: needinfo?(bzbarsky)
Comment 11•10 years ago
|
||
(In reply to Kevin Grandon :kgrandon from comment #4)
> Since this is not a new test, please try to track down the platform issue
> before disabling the test in the future. Also you should use TBPL-manifest
> instead of doing it in the test if possible.
>
> This is likely a gecko regression that broke us, and masking these issues
> does not do us good.
Kevin,
Sorry, I'll do that in the future. Learned.
Comment 12•10 years ago
|
||
We're generally executing promise resolution callbacks sooner than before - often in the same tick of the event loop in which "resolve" is called. If a resolution callback assumed that some other asynchronous DOM event was raised before it, it's possible that it is now resolving too soon.
Flags: needinfo?(paolo.mozmail)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 14•9 years ago
|
||
Inactive; closing (see bug 1180138).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•